From: Eric Sandeen <sandeen@sandeen.net>
To: Allison Collins <allison.henderson@oracle.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v4 1/2] xfs: Fix compiler warning in xfs_attr_node_removename_setup
Date: Tue, 28 Jul 2020 11:27:20 -0700 [thread overview]
Message-ID: <fb8e39e8-2571-2511-a41f-3f36c2cc1873@sandeen.net> (raw)
In-Reply-To: <20200728043220.17231-2-allison.henderson@oracle.com>
On 7/27/20 9:32 PM, Allison Collins wrote:
> Fix compiler warning for variable 'blk' set but not used in
> xfs_attr_node_removename_setup.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Allison Collins <allison.henderson@oracle.com>
Fixes: 534c7e150352 ("xfs: Add helper function xfs_attr_node_removename_setup")
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/libxfs/xfs_attr.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index d4583a0..e5ec9ed 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -1174,15 +1174,14 @@ int xfs_attr_node_removename_setup(
> struct xfs_da_state **state)
> {
> int error;
> - struct xfs_da_state_blk *blk;
>
> error = xfs_attr_node_hasname(args, state);
> if (error != -EEXIST)
> return error;
>
> - blk = &(*state)->path.blk[(*state)->path.active - 1];
> - ASSERT(blk->bp != NULL);
> - ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
> + ASSERT((*state)->path.blk[(*state)->path.active - 1].bp != NULL);
> + ASSERT((*state)->path.blk[(*state)->path.active - 1].magic ==
> + XFS_ATTR_LEAF_MAGIC);
>
> if (args->rmtblkno > 0) {
> error = xfs_attr_leaf_mark_incomplete(args, *state);
>
next prev parent reply other threads:[~2020-07-28 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 4:32 [PATCH v4 0/2] xfs: Fix compiler warnings Allison Collins
2020-07-28 4:32 ` [PATCH v4 1/2] xfs: Fix compiler warning in xfs_attr_node_removename_setup Allison Collins
2020-07-28 18:27 ` Eric Sandeen [this message]
2020-07-28 4:32 ` [PATCH v4 2/2] xfs: Fix compiler warning in xfs_attr_shortform_add Allison Collins
2020-07-28 18:36 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8e39e8-2571-2511-a41f-3f36c2cc1873@sandeen.net \
--to=sandeen@sandeen.net \
--cc=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).