From: "Tanya Brokhman" <tlinder@codeaurora.org>
To: <balbi@ti.com>
Cc: ablay@codeaurora.org, greg@kroah.com, linux-usb@vger.kernel.org,
'open list' <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org,
"'open list:OMAP USB SUPPORT'" <linux-omap@vger.kernel.org>,
"'open list:FREESCALE USB PER...'"
<linuxppc-dev@lists.ozlabs.org>
Subject: RE: [PATCH] usb:gadget: use min_t() macro instead of min()
Date: Mon, 13 Jun 2011 14:52:34 +0300 [thread overview]
Message-ID: <03b901cc29c0$6538e970$2faabc50$@org> (raw)
In-Reply-To: <20110613092438.GK3633@legolas.emea.dhcp.ti.com>
>
> On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote:
> > Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org>
>
> I need a sensible commit log for this. Why do we need to change all
> min() to min_t() ?
>
Actually, Alan asked me to make this change in one place in dummy_hcd. I
wasn't aware of the min_t macro before that. So when I searched the code for
other places I found quite a few and just thought that it would be "nicer"
to use min_t() instead of min() with casting.
So we don't "need" to make this change. Everything works as is. This patch
only makes the code look nicer, nothing more.
I can elaborate the above in the commit log if you want.
Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-06-13 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 11:14 [PATCH] usb:gadget: use min_t() macro instead of min() Tatyana Brokhman
2011-06-13 9:24 ` Felipe Balbi
2011-06-13 11:52 ` Tanya Brokhman [this message]
2011-06-13 11:57 ` Felipe Balbi
2011-06-13 14:38 ` Alan Stern
2011-06-13 18:07 ` Tanya Brokhman
2011-06-13 19:03 ` Alan Stern
2011-06-13 19:09 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03b901cc29c0$6538e970$2faabc50$@org' \
--to=tlinder@codeaurora.org \
--cc=ablay@codeaurora.org \
--cc=balbi@ti.com \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).