From: Michael Neuling <mikey@neuling.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/chrp: Fix enter_rtas() with CONFIG_VMAP_STACK
Date: Mon, 17 Feb 2020 09:40:08 +1100 [thread overview]
Message-ID: <04cdd26307a1eaebeacc039b207db92e0b6820bb.camel@neuling.org> (raw)
In-Reply-To: <159ecb0ab021c07fd2f383d4a083a43d16d67b92.1581669187.git.christophe.leroy@c-s.fr>
On Fri, 2020-02-14 at 08:33 +0000, Christophe Leroy wrote:
> With CONFIG_VMAP_STACK, data MMU has to be enabled
> to read data on the stack.
Can you describe what goes wrong without this? Some oops message? rtas blows up?
Get corrupt data?
Also can you say what you're actually doing (ie turning on MSR[DR])
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/kernel/entry_32.S | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
> index 0713daa651d9..bc056d906b51 100644
> --- a/arch/powerpc/kernel/entry_32.S
> +++ b/arch/powerpc/kernel/entry_32.S
> @@ -1354,12 +1354,17 @@ _GLOBAL(enter_rtas)
> mtspr SPRN_SRR0,r8
> mtspr SPRN_SRR1,r9
> RFI
> -1: tophys(r9,r1)
> +1: tophys_novmstack r9, r1
> +#ifdef CONFIG_VMAP_STACK
> + li r0, MSR_KERNEL & ~MSR_IR /* can take DTLB miss */
You're potentially turning on more than MSR DR here. This should be clear in the
commit message.
> + mtmsr r0
> + isync
> +#endif
> lwz r8,INT_FRAME_SIZE+4(r9) /* get return address */
> lwz r9,8(r9) /* original msr value */
> addi r1,r1,INT_FRAME_SIZE
> li r0,0
> - tophys(r7, r2)
> + tophys_novmstack r7, r2
> stw r0, THREAD + RTAS_SP(r7)
> mtspr SPRN_SRR0,r8
> mtspr SPRN_SRR1,r9
next prev parent reply other threads:[~2020-02-16 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 8:33 [PATCH] powerpc/chrp: Fix enter_rtas() with CONFIG_VMAP_STACK Christophe Leroy
2020-02-16 22:40 ` Michael Neuling [this message]
2020-02-17 6:40 ` Christophe Leroy
2020-02-18 0:40 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04cdd26307a1eaebeacc039b207db92e0b6820bb.camel@neuling.org \
--to=mikey@neuling.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).