LinuxPPC-Dev Archive on lore.kernel.org
 help / Atom feed
From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Nathan Lynch <nathanl@linux.ibm.com>,
	Tyrel Datwyler <tyreld@linux.ibm.com>
Cc: mingming.cao@ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] powerpc/pseries: Simplify cpu readd to use drc_index
Date: Fri, 17 May 2019 15:58:58 -0700
Message-ID: <05a4295b-dea5-bea2-5fd3-c8fbee7bac48@linux.vnet.ibm.com> (raw)
In-Reply-To: <8736leky3x.fsf@linux.ibm.com>

On 05/16/2019 12:17 PM, Nathan Lynch wrote:
> Tyrel Datwyler <tyreld@linux.ibm.com> writes:
>> The current dlpar_cpu_readd() takes in a cpu_id and uses that to look up
>> the cpus device_node so that we can get at the ibm,my-drc-index
>> property. The only user of cpu readd is an OF notifier call back. This
>> call back already has a reference to the device_node and therefore can
>> retrieve the drc_index from the device_node.
> 
> dlpar_cpu_readd is a hack to try to change the CPU-node relationship at
> runtime without destabilizing the system. It doesn't accomplish that and
> it should just be removed (and I'm working on that).
> 

I will politely disagree. We've done exactly this from userspace for years. My
experience still suggests that memory affinity is the problem area, and that the
work to push this all into the kernel originally was poorly tested.

-Tyrel


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  2:37 Tyrel Datwyler
2019-05-16  2:37 ` [PATCH 2/3] powerpc/pseries: Disable PRRN memory device tree trigger Tyrel Datwyler
2019-05-16  2:37 ` [PATCH 3/3] powerpc/pseries: Don't update cpu topology after PRRN event Tyrel Datwyler
2019-05-16 19:17 ` [PATCH 1/3] powerpc/pseries: Simplify cpu readd to use drc_index Nathan Lynch
2019-05-17 22:58   ` Tyrel Datwyler [this message]
2019-05-20 15:01     ` Nathan Lynch

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05a4295b-dea5-bea2-5fd3-c8fbee7bac48@linux.vnet.ibm.com \
    --to=tyreld@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingming.cao@ibm.com \
    --cc=nathanl@linux.ibm.com \
    --cc=tyreld@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LinuxPPC-Dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linuxppc-dev/0 linuxppc-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linuxppc-dev linuxppc-dev/ https://lore.kernel.org/linuxppc-dev \
		linuxppc-dev@lists.ozlabs.org linuxppc-dev@ozlabs.org linuxppc-dev@archiver.kernel.org
	public-inbox-index linuxppc-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.ozlabs.lists.linuxppc-dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox