From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (bilbo.ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3z0pfN6LFMzDrWw for ; Tue, 19 Dec 2017 04:57:48 +1100 (AEDT) Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by bilbo.ozlabs.org (Postfix) with ESMTP id 3z0pfL0B8Bz8vt8 for ; Tue, 19 Dec 2017 04:57:46 +1100 (AEDT) Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z0pf6185pz9t3F for ; Tue, 19 Dec 2017 04:57:31 +1100 (AEDT) Subject: Re: [PATCH] Fix parse_args cycle limit check. To: =?UTF-8?Q?Michal_Such=c3=a1nek?= Cc: Hari Bathini , linuxppc-dev , Andrew Morton , Ankit Kumar , lkml , Mahesh J Salgaonkar References: <20171215214702.7c7afba1@kitsune.suse.cz> <20171215214149.3692-1-msuchanek@suse.de> <12296c9b-d215-20d4-843e-4c9c9c06f0be@infradead.org> <20171218183413.53358649@kitsune.suse.cz> From: Randy Dunlap Message-ID: <0fd14d20-ae3a-07d9-ee73-fe08ee9af770@infradead.org> Date: Mon, 18 Dec 2017 09:57:17 -0800 MIME-Version: 1.0 In-Reply-To: <20171218183413.53358649@kitsune.suse.cz> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 12/18/2017 09:34 AM, Michal Suchánek wrote: > On Fri, 15 Dec 2017 15:49:09 -0800 > Randy Dunlap wrote: > >> On 12/15/2017 01:41 PM, Michal Suchanek wrote: >>> Actually args are supposed to be renamed to next so both and args >>> hold the previous argument so both can be passed to the callback. >>> This additionla patch >> >> additional >> >>> should fix up the rename. >> >> Would you try rewriting the first sentence, please? I don't get it. > > Ok, I guess this should be clarified. For the original patch and the > fixup squashed together this is what the patch is supposed to do: > > This patch adds variable for tracking the parameter which is currently > being processed. There is "args" variable which tracks the parameter > which will be processed next so this patch adds "next" variable to > track that and uses "args" to track the current argument. OK, thanks. -- ~Randy