linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Victor Gallardo <vgallardo@amcc.com>,
	Jeff Garzik <jgarzik@pobox.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v2] ibm_newemac: Add support for GPCS, SGMII andM88E1112 PHY
Date: Thu, 02 Oct 2008 22:37:48 +1000	[thread overview]
Message-ID: <1222951068.12264.109.camel@pasglop> (raw)
In-Reply-To: <20081002115507.GB2227@yoda.jdub.homelinux.org>

On Thu, 2008-10-02 at 07:55 -0400, Josh Boyer wrote:
> >Yep.  You could pull now if you'd like.  I have a few more patches I'd
> >like to get in before the merge window, but if it helps things I can do
> >those in a separate pull request.
> 
> Actually, it seems not.  I pulled in an older version of the patch.  I'll
> grab the new version today.

Victor, while at it, can you do a fixup patch on top of it that guards
the new feature with a Kconfig option like some of the other ones so
that the code for it doesn't get compiled in when building, for example.
for 405GP only ?

The trick is to have the option not be part of the possible mask, so
that the compiler optimises out the feature tests as if (0) (gcc
nowadays is supposedly smart enough to rip off the code when it finds
such constructs).

Thanks !

Cheers,
Ben.

  reply	other threads:[~2008-10-02 12:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02  6:37 [PATCH v2] ibm_newemac: Add support for GPCS, SGMII and M88E1112 PHY Victor Gallardo
2008-10-02  6:45 ` Benjamin Herrenschmidt
2008-10-02  7:30   ` [PATCH v2] ibm_newemac: Add support for GPCS, SGMII andM88E1112 PHY Victor Gallardo
2008-10-02  7:32     ` Benjamin Herrenschmidt
2008-10-02 10:33       ` Josh Boyer
2008-10-02 10:34         ` Benjamin Herrenschmidt
2008-10-02 10:56           ` Josh Boyer
2008-10-02 11:55             ` Josh Boyer
2008-10-02 12:37               ` Benjamin Herrenschmidt [this message]
2008-10-02 13:40                 ` [PATCH v2] ibm_newemac: Add support for GPCS, SGMIIandM88E1112 PHY Victor Gallardo
2008-10-02 13:48                   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222951068.12264.109.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=vgallardo@amcc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).