From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: [PATCH] uninorth agp: don't mark module parameter __devinit
Date: Wed, 29 Oct 2008 03:11:24 +0100 [thread overview]
Message-ID: <1225246284.1369.31.camel@johannes.berg> (raw)
A module parameter can possibly be shown via sysfs, which isn't a good
idea if the section has been removed, so remove the __devinit
annotation.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
Also fixes a section mismatch warning.
--- everything.orig/drivers/char/agp/uninorth-agp.c 2008-10-29 03:07:26.000000000 +0100
+++ everything/drivers/char/agp/uninorth-agp.c 2008-10-29 03:08:16.000000000 +0100
@@ -27,7 +27,7 @@
static int uninorth_rev;
static int is_u3;
-static char __devinitdata *aperture = NULL;
+static char *aperture = NULL;
static int uninorth_fetch_size(void)
{
next reply other threads:[~2008-10-29 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 2:11 Johannes Berg [this message]
2008-10-29 12:09 ` [PATCH] uninorth agp: don't mark module parameter __devinit Michel Dänzer
2008-10-29 12:12 ` Johannes Berg
2008-10-29 16:34 ` Michel Dänzer
2008-10-30 8:45 ` Johannes Berg
2008-10-30 8:50 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225246284.1369.31.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).