From: Hollis Blanchard <hollisb@us.ibm.com>
To: michael@ellerman.id.au
Cc: Milton Miller <miltonm@bga.com>, Wolfgang Denk <wd@denx.de>,
Ilya Yanok <yanok@emcraft.com>,
linux-ppc <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH] [v3] powerpc/4xx: work around CHIP11 errata in a more PAGE_SIZE-friendly way
Date: Tue, 25 Nov 2008 15:53:59 -0600 [thread overview]
Message-ID: <1227650039.7434.33.camel@localhost.localdomain> (raw)
In-Reply-To: <1227571828.20022.5.camel@localhost>
On Tue, 2008-11-25 at 11:10 +1100, Michael Ellerman wrote:
>
> Still, I think it would be better to only set memory_limit when the mem
> size is not a multiple of the PAGE_SIZE - so that memory_limit retains
> it's function as both the value of the limit and a boolean.
OK, how's this?
ppc: force memory size to be a multiple of PAGE_SIZE
Ensure that total memory size is page-aligned, because otherwise
mark_bootmem() gets upset.
This error case was triggered by using 64 KiB pages in the kernel while
arch/powerpc/boot/4xx.c arbitrarily reduced the amount of memory by 4096 (to
work around a chip bug that affects the last 256 bytes of physical memory).
Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
--- a/arch/powerpc/kernel/prom.c
+++ b/arch/powerpc/kernel/prom.c
@@ -1160,6 +1160,8 @@ static inline void __init phyp_dump_rese
void __init early_init_devtree(void *params)
{
+ unsigned long limit;
+
DBG(" -> early_init_devtree(%p)\n", params);
/* Setup flat device-tree pointer */
@@ -1200,7 +1202,15 @@ void __init early_init_devtree(void *par
early_reserve_mem();
phyp_dump_reserve_mem();
- lmb_enforce_memory_limit(memory_limit);
+ limit = memory_limit;
+ if (! limit) {
+ /* Ensure that total memory size is page-aligned, because
+ * otherwise mark_bootmem() gets upset. */
+ lmb_analyze();
+ limit = lmb_phys_mem_size() & PAGE_MASK;
+ }
+ lmb_enforce_memory_limit(limit);
+
lmb_analyze();
DBG("Phys. mem: %lx\n", lmb_phys_mem_size());
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2008-11-25 21:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 17:25 [PATCH] [v3] powerpc/4xx: work around CHIP11 errata in a more PAGE_SIZE-friendly way Milton Miller
2008-11-14 17:29 ` Milton Miller
2008-11-14 22:09 ` Hollis Blanchard
2008-11-18 20:33 ` Hollis Blanchard
2008-11-24 20:07 ` Hollis Blanchard
2008-11-25 0:10 ` Michael Ellerman
2008-11-25 17:10 ` Milton Miller
2008-11-25 21:17 ` Hollis Blanchard
2008-11-25 21:53 ` Hollis Blanchard [this message]
2008-11-25 23:43 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2008-11-12 0:06 Hollis Blanchard
2008-11-12 0:09 ` David Gibson
2008-11-12 4:37 ` Benjamin Herrenschmidt
2008-11-12 11:31 ` Josh Boyer
2008-11-12 11:52 ` Benjamin Herrenschmidt
2008-11-12 15:11 ` Hollis Blanchard
2008-11-12 20:44 ` Benjamin Herrenschmidt
2008-11-12 20:53 ` Josh Boyer
2008-11-13 19:54 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227650039.7434.33.camel@localhost.localdomain \
--to=hollisb@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=miltonm@bga.com \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).