linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Gary Thomas <gary@mlbassoc.com>
Subject: Re: [PATCH 00/33] My PS3-specific patches for 2.6.31
Date: Thu, 11 Jun 2009 12:01:12 +1000	[thread overview]
Message-ID: <1244685672.4674.10.camel@concordia> (raw)
In-Reply-To: <1244684128.5739.30.camel@pasglop>

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

On Thu, 2009-06-11 at 11:35 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2009-06-11 at 11:32 +1000, Michael Ellerman wrote:
> > The way I think of it is that the "merge window" is the time for
> > maintainers to merge with Linus.
> > 
> > So if you're sending patches to a maintainer you need to have sent all
> > your patches to them _before_ then. So the merge window for you is the
> > weeks prior to the "merge window".
> 
> Right. But a patch generally needs time to be reviewed, spun several
> times, etc... so just the week before the merge window is probably too
> late :-)

Sure. I mean that's when you should be sending polished code that's
ready to merge. In the same way that the maintainers are sending
polished ready to merge code to Linus during the merge window.

But absolutely, most patches need to be reviewed at least once before
they're ready, which is probably a week at best.


But really people should just be sending patches ASAP, even if they're
not 100% finished, so they get as much exposure as early as possible.

Sitting on patches waiting for the "right time" to send them is the
wrong approach IMHO.

cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

      reply	other threads:[~2009-06-11  2:01 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 14:38 [PATCH 00/33] My PS3-specific patches for 2.6.31 Geert Uytterhoeven
2009-06-10 14:38 ` [PATCH 01/33] ps3av: Set 16:9 aspect ratio for 720p video modes Geert Uytterhoeven
2009-06-10 14:38   ` [PATCH 02/33] ps3vram: Fix error path (return -EIO) for short read/write Geert Uytterhoeven
2009-06-10 14:38     ` [PATCH 03/33] ps3vram: Use proc_create_data() instead of proc_create() Geert Uytterhoeven
2009-06-10 14:38       ` [PATCH 04/33] ps3vram: Correct exchanged gotos in ps3vram_probe() error path Geert Uytterhoeven
2009-06-10 14:38         ` [PATCH 05/33] block: Add bio_list_peek() Geert Uytterhoeven
2009-06-10 14:38           ` [PATCH 06/33] ps3vram: Replace mutex by spinlock + bio_list Geert Uytterhoeven
2009-06-10 14:38             ` [PATCH 07/33] ps3fb: Remove useless debug checks in ps3fb_shutdown() Geert Uytterhoeven
2009-06-10 14:38               ` [PATCH 08/33] ps3fb: Inline functions in ps3fb_probe(), to ease cleanup in the error path Geert Uytterhoeven
2009-06-10 14:38                 ` [PATCH 09/33] ps3fb: Correct handling of device opening in ps3fb_probe() Geert Uytterhoeven
2009-06-10 14:38                   ` [PATCH 10/33] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h> Geert Uytterhoeven
2009-06-10 14:38                     ` [PATCH 11/33] ps3fb: GPU memory mapping cleanup Geert Uytterhoeven
2009-06-10 14:38                       ` [PATCH 12/33] ps3vram: " Geert Uytterhoeven
2009-06-10 14:38                         ` [PATCH 13/33] ps3fb/vram: Extract common GPU stuff into <asm/ps3gpu.h> Geert Uytterhoeven
2009-06-10 14:38                           ` [PATCH 14/33] ps3fb: Tear down FB setup during cleanup Geert Uytterhoeven
2009-06-10 14:38                             ` [PATCH 15/33] ps3vram: Remove no longer used ps3vram_priv.ddr_base Geert Uytterhoeven
2009-06-10 14:38                               ` [PATCH 16/33] ps3vram: Make ps3vram_priv.reports a void * Geert Uytterhoeven
2009-06-10 14:38                                 ` [PATCH 17/33] block/ps3: remove driver_data direct access of struct device Geert Uytterhoeven
2009-06-10 14:38                                   ` [PATCH 18/33] ps3: ps3_system_bus_device - Use dev_[gs]et_drvdata() instead of direct access Geert Uytterhoeven
2009-06-10 14:38                                     ` [PATCH 19/33] ps3: shorten ps3_system_bus_[gs]et_driver_data to ps3_system_bus_[gs]et_drvdata Geert Uytterhoeven
2009-06-10 14:38                                       ` [PATCH 20/33] ps3: ps3flash - Use ps3_system_bus_[gs]et_drvdata() instead of direct access Geert Uytterhoeven
2009-06-10 14:38                                         ` [PATCH 21/33] ps3: ps3rom " Geert Uytterhoeven
2009-06-10 14:38                                           ` [PATCH 22/33] ps3: ps3fb " Geert Uytterhoeven
2009-06-10 14:38                                             ` [PATCH 23/33] net/ps3: gelic - Add missing annotations Geert Uytterhoeven
2009-06-10 14:38                                               ` [PATCH 24/33] usb/ps3: " Geert Uytterhoeven
2009-06-10 14:39                                                 ` [PATCH 25/33] drivers/ps3: " Geert Uytterhoeven
2009-06-10 14:39                                                   ` [PATCH 26/33] sound/ps3: Fix checkpatch issues Geert Uytterhoeven
2009-06-10 14:39                                                     ` [PATCH 27/33] sound/ps3: Restructure driver source Geert Uytterhoeven
2009-06-10 14:39                                                       ` [PATCH 28/33] sound/ps3: Correct existing and add missing annotations Geert Uytterhoeven
2009-06-10 14:39                                                         ` [PATCH 29/33] ps3: Correct debug message in dma_ioc0_map_pages() Geert Uytterhoeven
2009-06-10 14:39                                                           ` [PATCH 30/33] ps3: Switch ps3_os_area_[gs]et_rtc_diff to EXPORT_SYMBOL_GPL() Geert Uytterhoeven
2009-06-10 14:39                                                             ` [PATCH 31/33] ps3: Replace direct file operations by callback Geert Uytterhoeven
2009-06-10 14:39                                                               ` [PATCH 32/33] ps3flash: Cache the last accessed FLASH chunk Geert Uytterhoeven
2009-06-10 14:39                                                                 ` [PATCH 33/33] ps3flash: Always read chunks of 256 KiB, and cache them Geert Uytterhoeven
2009-06-10 16:35                                                               ` [PATCH 31/33] ps3: Replace direct file operations by callback Geoff Levand
2009-06-10 16:35                                                             ` [PATCH 30/33] ps3: Switch ps3_os_area_[gs]et_rtc_diff to EXPORT_SYMBOL_GPL() Geoff Levand
2009-06-10 16:35                                                           ` [PATCH 29/33] ps3: Correct debug message in dma_ioc0_map_pages() Geoff Levand
2009-06-10 14:55                                                     ` [PATCH 26/33] sound/ps3: Fix checkpatch issues Takashi Iwai
2009-06-15  2:22                                                       ` Benjamin Herrenschmidt
2009-06-15  5:43                                                         ` Takashi Iwai
2009-06-15  5:51                                                           ` Benjamin Herrenschmidt
2009-06-15  6:07                                                             ` Takashi Iwai
2009-06-10 16:35                                                   ` [PATCH 25/33] drivers/ps3: Add missing annotations Geoff Levand
2009-06-10 16:35                                                 ` [PATCH 24/33] usb/ps3: " Geoff Levand
2009-06-15  6:31                                                 ` Benjamin Herrenschmidt
2009-06-10 16:35                                               ` [PATCH 23/33] net/ps3: gelic - " Geoff Levand
2009-06-15  6:31                                               ` Benjamin Herrenschmidt
2009-06-15  8:50                                                 ` David Miller
2009-06-10 16:35                                       ` [PATCH 19/33] ps3: shorten ps3_system_bus_[gs]et_driver_data to ps3_system_bus_[gs]et_drvdata Geoff Levand
2009-06-10 16:34                                     ` [PATCH 18/33] ps3: ps3_system_bus_device - Use dev_[gs]et_drvdata() instead of direct access Geoff Levand
2009-06-15  1:41                     ` [PATCH 10/33] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h> Benjamin Herrenschmidt
2009-06-15  7:05                       ` Arnd Bergmann
2009-06-15  7:12                         ` Benjamin Herrenschmidt
2009-07-29 12:06                           ` [PATCH] powerpc/cell: Move CBE_IOPTE_* to <asm/cell-regs.h> (was: Re: [PATCH 10/33] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h>) Geert Uytterhoeven
2009-06-15  1:39           ` [PATCH 05/33] block: Add bio_list_peek() Benjamin Herrenschmidt
2009-06-15  5:56             ` Jens Axboe
2009-06-10 16:34 ` [PATCH 00/33] My PS3-specific patches for 2.6.31 Geoff Levand
2009-06-10 21:43 ` Benjamin Herrenschmidt
2009-06-10 22:00   ` Nate Case
2009-06-10 22:26     ` Benjamin Herrenschmidt
     [not found]   ` <4A302B67.4000401@mlbassoc.com>
2009-06-11  0:48     ` Benjamin Herrenschmidt
2009-06-11  1:32       ` Michael Ellerman
2009-06-11  1:35         ` Benjamin Herrenschmidt
2009-06-11  2:01           ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244685672.4674.10.camel@concordia \
    --to=michael@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=gary@mlbassoc.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).