linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gao Guanhua <B22826@freescale.com>
To: sdhci-devel@lists.ossman.eu
Cc: linuxppc-dev@ozlabs.org, Gao Guanhua <B22826@freescale.com>
Subject: [PATCH 5/6] sdhci-of: Set the timeout to the max value
Date: Wed, 23 Sep 2009 17:08:11 +0800	[thread overview]
Message-ID: <1253696892-15262-5-git-send-email-B22826@freescale.com> (raw)
In-Reply-To: <1253696892-15262-4-git-send-email-B22826@freescale.com>

When access the card, the following error is reported:

  mmc0: Got data interrupt 0x00000020 even though no data operation was in progress.
  mmc0: Got data interrupt 0x00000020 even though no data operation was in progress.

so we skip the calculation of timeout and use the max value.
---
 arch/powerpc/boot/dts/p2020ds.dts |    1 +
 drivers/mmc/host/sdhci-of.c       |    3 +++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/p2020ds.dts b/arch/powerpc/boot/dts/p2020ds.dts
index 8b1056d..29989fb 100644
--- a/arch/powerpc/boot/dts/p2020ds.dts
+++ b/arch/powerpc/boot/dts/p2020ds.dts
@@ -461,6 +461,7 @@
 			interrupt-parent = <&mpic>;
 			fsl,sdhci-dma-broken;
 			fsl,sdhci-ahb2mag-irq-bypass;
+			fsl,sdhci-adjust-timeout;
 			clock-frequency = <0>;
 		};
 
diff --git a/drivers/mmc/host/sdhci-of.c b/drivers/mmc/host/sdhci-of.c
index 0bc75b3..0ff95d8 100644
--- a/drivers/mmc/host/sdhci-of.c
+++ b/drivers/mmc/host/sdhci-of.c
@@ -276,6 +276,9 @@ static int __devinit sdhci_of_probe(struct of_device *ofdev,
 	if (of_get_property(np, "fsl,sdhci-ahb2mag-irq-bypass", NULL))
 		host->quirks |= SDHCI_QUIRK_SET_AHB2MAG_IRQ_BYPASS;
 
+	if (of_get_property(np, "fsl,sdhci-adjust-timeout", NULL))
+		host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
+
 	clk = of_get_property(np, "clock-frequency", &size);
 	if (clk && size == sizeof(*clk) && *clk)
 		of_host->clock = *clk;
-- 
1.6.4

  reply	other threads:[~2009-09-23  9:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23  9:08 [PATCH 1/6] sdhci: Enable cache snooping Gao Guanhua
2009-09-23  9:08 ` [PATCH 2/6] P2020DS: Add sdhc support Gao Guanhua
2009-09-23  9:08   ` [PATCH 3/6] P2020DS: Fixup sdhc to use PIO mode Gao Guanhua
2009-09-23  9:08     ` [PATCH 4/6] sdhci: Fixup AHB2MAG IRQ bypass hardware workaround Gao Guanhua
2009-09-23  9:08       ` Gao Guanhua [this message]
2009-09-23  9:08         ` [PATCH 6/6] P2020DS: Remove sdhci-dma-broken and sdhci-ahb2mag-irq-bypass properties Gao Guanhua
2009-09-23 11:59           ` Anton Vorontsov
2009-09-24  8:22             ` Gao Guanhua-B22826
2009-09-23 11:55     ` [PATCH 3/6] P2020DS: Fixup sdhc to use PIO mode Anton Vorontsov
2009-09-24  8:28       ` Gao Guanhua-B22826
2009-11-05 13:52         ` Kumar Gala
2009-11-06  2:08           ` Gao Guanhua-B22826
2009-11-13  8:30           ` Gao Guanhua-B22826
2009-09-23 11:52 ` [PATCH 1/6] sdhci: Enable cache snooping Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253696892-15262-5-git-send-email-B22826@freescale.com \
    --to=b22826@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sdhci-devel@lists.ossman.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).