From: "Albrecht Dreß" <albrecht.dress@arcor.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Linux PPC Development <linuxppc-dev@ozlabs.org>,
devicetree-discuss@lists.ozlabs.org,
Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api
Date: Tue, 10 Nov 2009 21:26:17 +0100 [thread overview]
Message-ID: <1257884778.14374.5@antares> (raw)
In-Reply-To: <fa686aa40911101159y7bef3f9bte74e9aeb5c6e864b@mail.gmail.com> (from grant.likely@secretlab.ca on Tue Nov 10 20:59:22 2009)
[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]
Hi Grant:
Am 10.11.09 20:59 schrieb(en) Grant Likely:
> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dreß <albrecht.dress@arcor.de> wrote:
> > Use the MPC5200 GPT api for the WDT which drastically simplifies this file.
> >
> > Signed-off-by: Albrecht Dreß <albrecht.dress@arcor.de>
> > ---
> >
> > drivers/watchdog/mpc5200_wdt.c | 246 +++++++++++-----------------------------
> > 1 files changed, 65 insertions(+), 181 deletions(-)
>
>
> Can the WDT functionality just be merged entirely into
> arch/powerpc/platforms/52xx/mpc52xx_gpt.c, eliminating the need for
> this file entirely? I think I'd rather have all the GPT "built in"
> behaviour handled by a single driver.
I also thought about it, as it has IMHO the cleaner code, and it would have the extra benefit that the gpt-wdt api doesn't need to be public.
However, the reasons I hesitated to do so are:
- I don't want to remove a file someone else wrote (even it doesn't work);
- WDT code is shifted from drivers/watchdog to arch/powerpc/platforms/52xx which might not be the "logical" place from the directory layout's pov;
- a file living in arch/powerpc/platforms/52xx depends upon config options set from drivers/watchdog/Kconfig which may be confusing.
You see these are more political/cosmetical questions, so I would prefer to leave the decision to the maintainers (i.e. you and Wim). Preparing a fully merged driver is actually a matter of minutes!
Thanks,
Albrecht.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2009-11-10 22:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 19:43 [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api Albrecht Dreß
2009-11-10 19:59 ` Grant Likely
2009-11-10 20:26 ` Albrecht Dreß [this message]
2009-11-10 21:07 ` Grant Likely
2009-11-11 8:32 ` Aw: " Albrecht Dreß
2009-11-11 20:18 ` Grant Likely
2009-11-12 21:36 ` Wim Van Sebroeck
2009-11-13 6:21 ` Grant Likely
2009-12-08 20:48 ` Wim Van Sebroeck
2009-12-08 21:21 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257884778.14374.5@antares \
--to=albrecht.dress@arcor.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).