From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2D8031007D1 for ; Sat, 28 Nov 2009 08:35:26 +1100 (EST) Subject: Re: [RFC PATCH 12/19] powerpc: gamecube: platform support From: Benjamin Herrenschmidt To: Segher Boessenkool In-Reply-To: References: <1258927311-4340-1-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-2-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-3-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-4-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-5-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-6-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-7-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-8-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-9-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-10-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-11-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-12-git-send-email-albert_herranz@yahoo.es> <1258927311-4340-13-git-send-email-albert_herranz@yahoo.es> <4B0D6837.4020407@yahoo.es> <76CF44C1-3CC1-43B5-958D-E1A7984A44A9@kernel.crashing.org> <4B0EFC1D.5030806@yahoo.es> Content-Type: text/plain; charset="UTF-8" Date: Sat, 28 Nov 2009 08:35:18 +1100 Message-ID: <1259357718.2076.7.camel@pasglop> Mime-Version: 1.0 Cc: Albert Herranz , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2009-11-27 at 01:09 +0100, Segher Boessenkool wrote: > >>> We need it as it currently doesn't match with the default bus ids. > >> > >>> Should I introduce a .type property matching any of those above > >>> in the > >>> soc node, and get rid of the explicit bus probe? > >> > >> You don't need any fake bus as far as I can see, just probe the > >> devices > >> you want. > > > > But it's way easier to let the bus probe do it for us. I don't see > > the win here. > > As long as this doesn't leak into the device tree in any way, I don't > care. How's that? :-) I still like having the node that encloses all the devices. Not sure why, but I like it :-) Cheers, Ben.