From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joel Schopp <jschopp@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] Add static fields to ibm,client-architecture call
Date: Fri, 15 Jan 2010 13:52:14 +1100 [thread overview]
Message-ID: <1263523934.724.381.camel@pasglop> (raw)
In-Reply-To: <1263523863.724.380.camel@pasglop>
Oh and :
> > Signed-off-by:Joel Schopp<jschopp@austin.ibm.com>
^ space ^ space
Thanks !
Cheers,
Ben.
> The marker should be here or the line below:
>
> > Index: linux-2.6.git/arch/powerpc/kernel/prom_init.c
> > ===================================================================
>
> Would also end up in the comments.
>
> The rest looks fine.
>
> Cheers,
> Ben.
>
> > --- linux-2.6.git.orig/arch/powerpc/kernel/prom_init.c
> > +++ linux-2.6.git/arch/powerpc/kernel/prom_init.c
> > @@ -654,6 +656,9 @@ static void __init early_cmdline_parse(v
> > #define OV5_CMO 0x00
> > #endif
> >
> > +/* Option Vector 6: IBM PAPR hints */
> > +#define OV6_LINUX 0x02 /* Linux is our OS */
> > +
> > /*
> > * The architecture vector has an array of PVR mask/value pairs,
> > * followed by # option vectors - 1, followed by the option vectors.
> > @@ -665,7 +670,7 @@ static unsigned char ibm_architecture_ve
> > W(0xffffffff), W(0x0f000003), /* all 2.06-compliant */
> > W(0xffffffff), W(0x0f000002), /* all 2.05-compliant */
> > W(0xfffffffe), W(0x0f000001), /* all 2.04-compliant and earlier */
> > - 5 - 1, /* 5 option vectors */
> > + 6 - 1, /* 6 option vectors */
> >
> > /* option vector 1: processor architectures supported */
> > 3 - 2, /* length */
> > @@ -697,12 +702,24 @@ static unsigned char ibm_architecture_ve
> > 0, /* don't halt */
> >
> > /* option vector 5: PAPR/OF options */
> > - 5 - 2, /* length */
> > + 13 - 2, /* length */
> > 0, /* don't ignore, don't halt */
> > OV5_LPAR | OV5_SPLPAR | OV5_LARGE_PAGES | OV5_DRCONF_MEMORY |
> > OV5_DONATE_DEDICATE_CPU | OV5_MSI,
> > 0,
> > OV5_CMO,
> > + 0,
> > + 0,
> > + 0,
> > + 0,
> > + W(NR_CPUS), /* number of cores supported*/
> > +
> > + /* option vector 6: IBM PAPR hints */
> > + 4 - 2, /* length */
> > + 0,
> > + 0,
> > + OV6_LINUX,
> > +
> > };
> >
> > /* Old method - ELF header with PT_NOTE sections */
> >
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2010-01-15 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 20:38 [PATCH 0/2] Add max CPU nodes field to ibm,client-architecture call Joel Schopp
2010-01-14 20:40 ` [PATCH 1/2] Add static fields " Joel Schopp
2010-01-14 23:01 ` Joel Schopp
2010-01-15 2:51 ` Benjamin Herrenschmidt
2010-01-15 2:52 ` Benjamin Herrenschmidt [this message]
2010-02-01 22:50 ` [PATCHv2 " Joel Schopp
2010-01-14 20:41 ` [PATCH 2/2] Update ibm,client-architecture call field based on device tree Joel Schopp
2010-01-15 2:58 ` Benjamin Herrenschmidt
2010-02-01 22:51 ` [PATCHv2 " Joel Schopp
2010-02-02 3:48 ` Tony Breeds
2010-02-02 18:37 ` Joel Schopp
2010-02-04 3:27 ` Benjamin Herrenschmidt
2010-02-01 22:50 ` [PATCHv2 0/2] Add max CPU nodes field to ibm,client-architecture call Joel Schopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263523934.724.381.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jschopp@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).