From: Milton Miller <miltonm@bga.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, "K.Prasad" <prasad@linux.vnet.ibm.com>
Subject: [RFC PATCH] powerpc: Emulate most load and store instructions in emulate_step()
Date: Fri, 21 May 2010 11:35:48 -0500 [thread overview]
Message-ID: <1274459748_7091@mail4.comsite.net> (raw)
In-Reply-To: <20100520124955.GA29903@brick.ozlabs.ibm.com>
[resending to hit the list]
> + if (regs->gpr[0] == 0x1ebe &&
> + cpu_has_feature(CPU_FTR_REAL_LE)) {
> + regs->msr ^= MSR_LE;
> + goto instr_done;
> + }
> regs->gpr[9] = regs->gpr[13];
> + regs->gpr[10] = MSR_KERNEL;
>
this hunk didn't seem to be mentioned in the change log
>+ static inline unsigned long xform_ea(unsigned int instr, struct pt_regs *regs)
..
> + if (ra) {
> + ea += regs->gpr[ra];
> + if (instr & 0x40) /* update forms */
> + regs->gpr[ra] = ea;
> + }
if the instruction faults, we shouldn't update ra
> + case 62: /* std[u] */
> + val = regs->gpr[rd];
> + switch (instr & 3) {
> + case 0: /* ld */
> + err = write_mem(val, dsform_ea(instr, regs), 8, regs);
> + goto ldst_done;
> + case 1: /* ldu */
> + err = write_mem(val, dsform_ea(instr, regs), 8, regs);
> + goto ldst_done;
> + }
> + break;
>
comments seem to be copied
milton
next prev parent reply other threads:[~2010-05-21 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 12:49 [RFC PATCH] powerpc: Emulate most load and store instructions in emulate_step() Paul Mackerras
2010-05-21 16:35 ` Milton Miller [this message]
2010-05-27 14:12 ` [RFC PATCH] powerpc: Emulate nop too Ananth N Mavinakayanahalli
2010-05-27 20:22 ` Kumar Gala
2010-05-28 3:52 ` Ananth N Mavinakayanahalli
2010-05-28 2:05 ` Paul Mackerras
2010-05-28 5:19 ` powerpc: remove resume_execution() in kprobes Ananth N Mavinakayanahalli
2010-05-28 2:28 ` [RFC PATCH] powerpc: Emulate nop too Michael Neuling
2010-05-28 4:16 ` Ananth N Mavinakayanahalli
2010-05-28 4:23 ` Michael Neuling
2010-05-28 5:54 ` Ananth N Mavinakayanahalli
2010-06-02 5:25 ` [RFC PATCH] powerpc: Emulate most load and store instructions in emulate_step() K.Prasad
2010-06-02 6:00 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274459748_7091@mail4.comsite.net \
--to=miltonm@bga.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=prasad@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).