From: David Woodhouse <dwmw2@infradead.org>
To: "tiejun.chen" <tiejun.chen@windriver.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
dedekind1@gmail.com, Zang Roy-R61911 <r61911@freescale.com>,
Lan Chunhe-B25806 <B25806@freescale.com>,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
akpm@linux-foundation.org,
Gala Kumar-B11780 <B11780@freescale.com>
Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices
Date: Mon, 25 Oct 2010 15:15:27 +0100 [thread overview]
Message-ID: <1288016127.5674.45.camel@macbook.infradead.org> (raw)
In-Reply-To: <4CBC1775.6000706@windriver.com>
On Mon, 2010-10-18 at 17:46 +0800, tiejun.chen wrote:
>
> >>> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but here
> >>> of_iomap() is already failed you should skip iounmap() fsl_lbc_ctrl_dev->regs
> >>> again. So you should improve that as the following on 'err', or layout 'err'
> >>> in
> >>> gain.
> >>> ------
> >>> if(fsl_lbc_ctrl_dev->regs)
> >>> iounmap(fsl_lbc_ctrl_dev->regs);
> >>>
> >>> Tiejun
> >> You are right!
> >> How about
> >>
> >> if (!fsl_lbc_ctrl_dev->regs) {
> >> dev_err(&dev->dev, "failed to get memory region\n");
> >> kfree(fsl_lbc_ctrl_dev);
> >> return -ENOMEM;
> >> }
> >
> > Although this is a big problem, I prefer to return 'ENXIO' :)
> ^
> Typo: is not a ......
My God! Why did you *both* repeat over 400 lines of patch, over and over
again, just for this?
Please, make sure you quote *only* what you actually need to quote for
context. Don't make me implement a filter for the list which rejects
messages that are more than 90% quotation.
--
dwmw2
next prev parent reply other threads:[~2010-10-25 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 7:22 [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices Roy Zang
2010-10-18 7:22 ` [PATCH 2/2] P4080/mtd: Fix the freescale lbc issue with 36bit mode Roy Zang
2010-10-18 8:55 ` [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices tiejun.chen
2010-10-18 9:30 ` Zang Roy-R61911
2010-10-18 9:44 ` tiejun.chen
2010-10-18 9:46 ` tiejun.chen
2010-10-25 14:15 ` David Woodhouse [this message]
2010-10-18 16:06 ` Scott Wood
2010-10-19 1:35 ` tiejun.chen
2010-10-19 6:37 ` Zang Roy-R61911
2010-10-19 13:18 ` Kumar Gala
2010-10-20 5:12 ` Zang Roy-R61911
2010-10-20 6:54 ` Kumar Gala
2010-10-20 8:33 ` Zang Roy-R61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288016127.5674.45.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=B07421@freescale.com \
--cc=B11780@freescale.com \
--cc=B25806@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=r61911@freescale.com \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).