linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Ben Dooks <ben@simtec.co.uk>,
	linux-fbdev@vger.kernel.org, devicetree-discuss@ozlabs.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Vincent Sanders <vince@simtec.co.uk>,
	linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>,
	Paul Mundt <lethal@linux-sh.org>, Heiko Schocher <hs@denx.de>,
	Wolfgang Denk <wd@denx.de>
Subject: [PATCH v6 4/6] video, sm501: add OF binding to support SM501
Date: Tue, 22 Mar 2011 09:27:30 +0100	[thread overview]
Message-ID: <1300782452-528-5-git-send-email-hs@denx.de> (raw)
In-Reply-To: <1300782452-528-1-git-send-email-hs@denx.de>

- add binding to OF, compatible name "smi,sm501"

Signed-off-by: Heiko Schocher <hs@denx.de>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
cc: Wolfram Sang <w.sang@pengutronix.de>
cc: Grant Likely <grant.likely@secretlab.ca>
cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
cc: linux-fbdev@vger.kernel.org
cc: devicetree-discuss@ozlabs.org
cc: Ben Dooks <ben@simtec.co.uk>
cc: Vincent Sanders <vince@simtec.co.uk>
cc: Samuel Ortiz <sameo@linux.intel.com>
cc: linux-kernel@vger.kernel.org
cc: Randy Dunlap <rdunlap@xenotime.net>
cc: Wolfgang Denk <wd@denx.de>
cc: Paul Mundt <lethal@linux-sh.org>
---
- changes since v1:
  add Ben Dooks, Vincent Sanders and Samuel Ortiz to cc, as suggested from
  Paul Mundt.
- changes since v2:
  add comments from Randy Dunlap:
  - move parameter documentation to Documentation/fb/sm501.txt
- changes since v3:
  - rebased against v2.6.38-rc2
  - split in 3 patches
    - of support patch
      - get rid of "#if defined(CONFIG_PPC_MPC52xx)" usage
        hide this in DTS, as Paul suggested.
    - i/o routine patch
    - edid support patch
- changes since v4
  replace remaining CONFIG_PPC_MPC52xx with CONFIG_OF, as
  it is no longer MPC52xx only.
- changes since v5
  free edid_data after its usage, as it is no longer needed,
  suggested from Paul Mundt. Also fall back to default if
  kmemdup(edid_data) fails.
- changes for v6:
  - repost complete patchserie
  - rebased against current head

 Documentation/powerpc/dts-bindings/sm501.txt |   34 +++++++++++++++++++++++++
 drivers/mfd/sm501.c                          |    8 +++++-
 drivers/video/sm501fb.c                      |   35 +++++++++++++++++++++++++-
 3 files changed, 75 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/powerpc/dts-bindings/sm501.txt

diff --git a/Documentation/powerpc/dts-bindings/sm501.txt b/Documentation/powerpc/dts-bindings/sm501.txt
new file mode 100644
index 0000000..7d319fb
--- /dev/null
+++ b/Documentation/powerpc/dts-bindings/sm501.txt
@@ -0,0 +1,34 @@
+* SM SM501
+
+The SM SM501 is a LCD controller, with proper hardware, it can also
+drive DVI monitors.
+
+Required properties:
+- compatible : should be "smi,sm501".
+- reg : contain two entries:
+    - First entry: System Configuration register
+    - Second entry: IO space (Display Controller register)
+- interrupts : SMI interrupt to the cpu should be described here.
+- interrupt-parent : the phandle for the interrupt controller that
+  services interrupts for this device.
+
+Optional properties:
+- mode : select a video mode:
+    <xres>x<yres>[-<bpp>][@<refresh>]
+- edid : verbatim EDID data block describing attached display.
+  Data from the detailed timing descriptor will be used to
+  program the display controller.
+- little-endian: availiable on big endian systems, to
+  set different foreign endian.
+- big-endian: availiable on little endian systems, to
+  set different foreign endian.
+
+Example for MPC5200:
+	display@1,0 {
+		compatible = "smi,sm501";
+		reg = <1 0x00000000 0x00800000
+		       1 0x03e00000 0x00200000>;
+		interrupts = <1 1 3>;
+		mode = "640x480-32@60";
+		edid = [edid-data];
+	};
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index 558d5f3..574f696 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1377,7 +1377,7 @@ static int __devinit sm501_init_dev(struct sm501_devdata *sm)
 			sm501_register_gpio(sm);
 	}
 
-	if (pdata->gpio_i2c != NULL && pdata->gpio_i2c_nr > 0) {
+	if (pdata && pdata->gpio_i2c != NULL && pdata->gpio_i2c_nr > 0) {
 		if (!sm501_gpio_isregistered(sm))
 			dev_err(sm->dev, "no gpio available for i2c gpio.\n");
 		else
@@ -1735,10 +1735,16 @@ static struct pci_driver sm501_pci_driver = {
 
 MODULE_ALIAS("platform:sm501");
 
+static struct of_device_id __devinitdata of_sm501_match_tbl[] = {
+	{ .compatible = "smi,sm501", },
+	{ /* end */ }
+};
+
 static struct platform_driver sm501_plat_driver = {
 	.driver		= {
 		.name	= "sm501",
 		.owner	= THIS_MODULE,
+		.of_match_table = of_sm501_match_tbl,
 	},
 	.probe		= sm501_plat_probe,
 	.remove		= sm501_plat_remove,
diff --git a/drivers/video/sm501fb.c b/drivers/video/sm501fb.c
index f31252c..f275385 100644
--- a/drivers/video/sm501fb.c
+++ b/drivers/video/sm501fb.c
@@ -1729,6 +1729,15 @@ static int sm501fb_init_fb(struct fb_info *fb,
 		FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT |
 		FBINFO_HWACCEL_XPAN | FBINFO_HWACCEL_YPAN;
 
+#if defined(CONFIG_OF)
+#ifdef __BIG_ENDIAN
+	if (of_get_property(info->dev->parent->of_node, "little-endian", NULL))
+		fb->flags |= FBINFO_FOREIGN_ENDIAN;
+#else
+	if (of_get_property(info->dev->parent->of_node, "big-endian", NULL))
+		fb->flags |= FBINFO_FOREIGN_ENDIAN;
+#endif
+#endif
 	/* fixed data */
 
 	fb->fix.type		= FB_TYPE_PACKED_PIXELS;
@@ -1933,8 +1942,32 @@ static int __devinit sm501fb_probe(struct platform_device *pdev)
 	}
 
 	if (info->pdata == NULL) {
-		dev_info(dev, "using default configuration data\n");
+		int found = 0;
+#if defined(CONFIG_OF)
+		struct device_node *np = pdev->dev.parent->of_node;
+		const u8 *prop;
+		const char *cp;
+		int len;
+
 		info->pdata = &sm501fb_def_pdata;
+		if (np) {
+			/* Get EDID */
+			cp = of_get_property(np, "mode", &len);
+			if (cp)
+				strcpy(fb_mode, cp);
+			prop = of_get_property(np, "edid", &len);
+			if (prop && len == EDID_LENGTH) {
+				info->edid_data = kmemdup(prop, EDID_LENGTH,
+							  GFP_KERNEL);
+				if (info->edid_data)
+					found = 1;
+			}
+		}
+#endif
+		if (!found) {
+			dev_info(dev, "using default configuration data\n");
+			info->pdata = &sm501fb_def_pdata;
+		}
 	}
 
 	/* probe for the presence of each panel */
-- 
1.7.4

  parent reply	other threads:[~2011-03-22  8:36 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-04  8:23 [PATCH 1/2] video, sm501: add OF binding to support SM501 Heiko Schocher
2010-12-04  8:23 ` [PATCH 2/2] powerpc, video: add SM501 support for charon board Heiko Schocher
2010-12-07  6:59   ` [PATCH 2/2 v2] " Heiko Schocher
2010-12-11  6:31   ` [PATCH v3 2/2] " Heiko Schocher
2011-01-24  9:57   ` [PATCH 4/4 v4] " Heiko Schocher
2011-01-25  6:45   ` [PATCH 4/4 v5] " Heiko Schocher
2011-01-25  6:49     ` Paul Mundt
2011-01-25  7:07       ` Heiko Schocher
2010-12-08  5:36 ` [PATCH 1/2] video, sm501: add OF binding to support SM501 Paul Mundt
2010-12-09  6:49   ` Heiko Schocher
2010-12-09 15:03     ` Samuel Ortiz
2010-12-11  6:31 ` [PATCH v2 " Heiko Schocher
2010-12-11 18:28   ` Randy Dunlap
2010-12-11 22:34   ` Randy Dunlap
2010-12-13  7:01     ` Heiko Schocher
2011-01-06  4:47   ` Paul Mundt
2011-01-24  9:57 ` [PATCH 1/4 v4] video, sm501: add I/O functions for use on powerpc Heiko Schocher
2011-01-31 10:50   ` Samuel Ortiz
2011-01-24  9:57 ` [PATCH 2/4 v4] video, sm501: add edid and commandline support Heiko Schocher
2011-01-25  7:51   ` Paul Mundt
2011-01-25  8:04     ` Heiko Schocher
2011-01-24  9:57 ` [PATCH 3/4 v4] video, sm501: add OF binding to support SM501 Heiko Schocher
2011-01-25  6:38   ` Paul Mundt
2011-01-31 10:52   ` Samuel Ortiz
2011-01-25  7:20 ` Heiko Schocher
2011-01-25  7:48   ` Paul Mundt
2011-01-25  8:02     ` Heiko Schocher
2011-01-26  7:21 ` [PATCH 2/4 v5] video, sm501: add edid and commandline support Heiko Schocher
2011-01-26  7:21 ` [PATCH 3/4 v5] video, sm501: add OF binding to support SM501 Heiko Schocher
2011-03-15  7:26   ` Heiko Schocher
2011-03-16 15:36     ` Paul Mundt
2011-03-17  6:12       ` Heiko Schocher
2011-03-22  8:20         ` Paul Mundt
2011-03-22  8:25           ` Heiko Schocher
2011-02-06 23:45 ` [PATCH 1/2] " Benjamin Herrenschmidt
2011-03-22  8:27 ` [PATCH v6 0/6] powerpc, 52xx: add charon board support Heiko Schocher
2011-03-22  8:27   ` [PATCH v1 1/6] powerpc, 5200: add support for charon board Heiko Schocher
2011-03-22  9:06     ` Wolfram Sang
2011-03-22  8:27   ` [PATCH v6 2/6] video, sm501: add I/O functions for use on powerpc Heiko Schocher
2011-05-02 22:24     ` Grant Likely
2011-03-22  8:27   ` [PATCH v6 3/6] video, sm501: add edid and commandline support Heiko Schocher
2011-05-02 22:27     ` Grant Likely
2011-05-02 22:37       ` Grant Likely
2011-05-03  5:27         ` Heiko Schocher
2011-05-03  5:43           ` Grant Likely
2011-03-22  8:27   ` Heiko Schocher [this message]
2011-05-02 22:28     ` [PATCH v6 4/6] video, sm501: add OF binding to support SM501 Grant Likely
2011-03-22  8:27   ` [PATCH v6 5/6] powerpc, video: add SM501 support for charon board Heiko Schocher
2011-03-22  8:27   ` [PATCH v6 6/6] powerpc, tqm5200: update tqm5200_defconfig to fit " Heiko Schocher
2011-03-22  9:10     ` Wolfram Sang
2011-05-02 22:31       ` Grant Likely
2011-03-22 20:58   ` [PATCH v6 0/6] powerpc, 52xx: add charon board support Grant Likely
2011-05-02 22:14   ` Grant Likely
2011-05-03  5:17     ` Heiko Schocher
2011-05-03  5:42       ` Grant Likely
2011-05-03  7:24         ` Heiko Schocher
2011-05-03 13:22           ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300782452-528-5-git-send-email-hs@denx.de \
    --to=hs@denx.de \
    --cc=ben@simtec.co.uk \
    --cc=devicetree-discuss@ozlabs.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=rdunlap@xenotime.net \
    --cc=sameo@linux.intel.com \
    --cc=vince@simtec.co.uk \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).