From: Lei Xu <B33228@freescale.com>
To: <linux-kernel@vger.kernel.org>
Cc: linux-pci@vger.kernel.org, kumar.gala@freescale.com,
linuxppc-dev@lists.ozlabs.org, Lei Xu <B33228@freescale.com>
Subject: [PATCH] PCI: portdrv: fix irq initialization on FSL pcie host controller
Date: Fri, 22 Apr 2011 15:43:39 +0800 [thread overview]
Message-ID: <1303458219-31915-1-git-send-email-B33228@freescale.com> (raw)
Root complex ports for Freescale PCIe host controller only receive
interrupts, so if there is no irq setting for RC, it should not return
error, otherwise it may result the PCIe host controller is disabled.
Signed-off-by: Lei Xu <B33228@freescale.com>
---
drivers/pci/pcie/portdrv_core.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
index 595654a..95e64c8 100644
--- a/drivers/pci/pcie/portdrv_core.c
+++ b/drivers/pci/pcie/portdrv_core.c
@@ -209,7 +209,10 @@ static int init_service_irqs(struct pci_dev *dev, int *irqs, int mask)
irqs[i] = irq;
irqs[PCIE_PORT_SERVICE_VC_SHIFT] = -1;
- if (irq < 0)
+ /* Root complex ports for Freescale PCIe host controller only
+ * receive interrupts, so if there is no irq setting for RC,
+ * it should not return error. */
+ if ((irq < 0) && (dev->pcie_type != PCI_EXP_TYPE_ROOT_PORT))
return -ENODEV;
return 0;
}
--
1.7.0.4
next reply other threads:[~2011-04-22 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 7:43 Lei Xu [this message]
2011-04-28 8:01 ` [PATCH] PCI: portdrv: fix irq initialization on FSL pcie host controller Xu Lei
2011-05-07 16:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303458219-31915-1-git-send-email-B33228@freescale.com \
--to=b33228@freescale.com \
--cc=kumar.gala@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).