From: "Matthew L. Creech" <mlcreech@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org,
rick22@wi.rr.com, mhench@elutions.com
Subject: [PATCH] mtd: eLBC NAND: remove bogus ECC read-back
Date: Tue, 5 Jul 2011 15:59:57 -0400 [thread overview]
Message-ID: <1309895997-29969-1-git-send-email-mlcreech@gmail.com> (raw)
In-Reply-To: <CAPBSBxqRywJjCfk_iuDLxn1HbuqPjJRJS=SkRQ3-Ge7SinbSBg@mail.gmail.com>
From: Mike Hench <mhench@elutions.com>
The eLBC NAND driver currently follows up each program/write operation with a
read-back of the page, in order to [ostensibly] fill in ECC data for the
caller. However, the page address used for this read is always -1, so the read
will never work correctly. Remove this useless (and potentially problematic)
block of code.
Signed-off-by: Matthew L. Creech <mlcreech@gmail.com>
---
drivers/mtd/nand/fsl_elbc_nand.c | 17 -----------------
1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 0bb254c..050a2fc 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -455,23 +455,6 @@ static void fsl_elbc_cmdfunc(struct mtd_info *mtd, unsigned int command,
fsl_elbc_run_command(mtd);
- /* Read back the page in order to fill in the ECC for the
- * caller. Is this really needed?
- */
- if (full_page && elbc_fcm_ctrl->oob_poi) {
- out_be32(&lbc->fbcr, 3);
- set_addr(mtd, 6, page_addr, 1);
-
- elbc_fcm_ctrl->read_bytes = mtd->writesize + 9;
-
- fsl_elbc_do_read(chip, 1);
- fsl_elbc_run_command(mtd);
-
- memcpy_fromio(elbc_fcm_ctrl->oob_poi + 6,
- &elbc_fcm_ctrl->addr[elbc_fcm_ctrl->index], 3);
- elbc_fcm_ctrl->index += 3;
- }
-
elbc_fcm_ctrl->oob_poi = NULL;
return;
}
--
1.6.3.3
next prev parent reply other threads:[~2011-07-05 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 20:54 NAND BBT corruption on MPC83xx Matthew L. Creech
2011-06-17 21:34 ` Scott Wood
2011-06-18 17:55 ` Mike Hench
2011-06-20 11:22 ` Atlant Schmidt
2011-06-23 8:31 ` Artem Bityutskiy
2011-06-20 15:20 ` Matthew L. Creech
2011-07-05 19:58 ` Matthew L. Creech
2011-07-05 19:59 ` Matthew L. Creech [this message]
2011-07-05 20:15 ` [PATCH] mtd: eLBC NAND: remove bogus ECC read-back Scott Wood
2011-07-05 22:35 ` [PATCH v2] mtd: eLBC NAND: remove elbc_fcm_ctrl->oob_poi Matthew L. Creech
2011-07-05 23:01 ` Scott Wood
2011-07-05 23:14 ` Matthew L. Creech
2011-07-05 23:14 ` [PATCH v3] " Matthew L. Creech
2011-07-06 7:23 ` Artem Bityutskiy
2011-07-11 15:30 ` NAND BBT corruption on MPC83xx Matthew L. Creech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309895997-29969-1-git-send-email-mlcreech@gmail.com \
--to=mlcreech@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhench@elutions.com \
--cc=rick22@wi.rr.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).