From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: vinod.koul@intel.com, linux-kernel@vger.kernel.org,
miltonm@bga.com, nacc@us.ibm.com, dan.j.williams@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/4] dma-mapping: add get_required_mask if arch overrides default
Date: Thu, 01 Sep 2011 15:35:11 +1000 [thread overview]
Message-ID: <1314855311.4145.8.camel@pasglop> (raw)
In-Reply-To: <20110629171304B.fujita.tomonori@lab.ntt.co.jp>
On Wed, 2011-06-29 at 17:19 +0900, FUJITA Tomonori wrote:
> On Fri, 24 Jun 2011 12:05:23 -0700
> Nishanth Aravamudan <nacc@us.ibm.com> wrote:
>
> > From: Milton Miller <miltonm@bga.com>
> >
> > If an architecture sets ARCH_HAS_DMA_GET_REQUIRED_MASK and has settable
> > dma_map_ops, the required mask may change by the ops implementation.
> > For example, a system that always has an mmu inline may only require 32
> > bits while a swiotlb would desire bits to cover all of memory.
> >
> > Therefore add the field if the architecture does not use the generic
> > definition of dma_get_required_mask. The first use will by by powerpc.
> > Note that this does add some dependency on the order in which files are
> > visible here.
.../...
> If you add get_required_mask to dma_map_ops, we should clean up ia64
> too and implement the generic proper version in
> dma-mapping-common.h. Then we kill ARCH_HAS_DMA_GET_REQUIRED_MASK
> ifdef hack. Otherwise, I don't think it makes sense to add this to
> dma_map_ops.
In the meantime, can I have an ack so I can include this along with the
rest of Milton's patches ? It's been around for a while now :-)
I'm a bit late for producing a powerpc-next (due to travelling).
Cheers,
Ben.
next prev parent reply other threads:[~2011-09-01 5:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 19:05 [PATCH 0/4] pseries/iommu bug-fixes and cleanups for dynamic dma windows Nishanth Aravamudan
2011-06-24 19:05 ` [PATCH 1/4] powerpc: override dma_get_required_mask by platform hook and ops Nishanth Aravamudan
2011-06-24 19:05 ` [PATCH 2/4] dma-mapping: add get_required_mask if arch overrides default Nishanth Aravamudan
2011-06-29 8:19 ` FUJITA Tomonori
2011-09-01 5:35 ` Benjamin Herrenschmidt [this message]
2011-09-16 18:51 ` FUJITA Tomonori
2011-06-24 19:05 ` [PATCH 3/4] powerpc: use the newly added get_required_mask dma_map_ops hook Nishanth Aravamudan
2011-06-25 15:41 ` Geoff Levand
2011-06-24 19:05 ` [PATCH 4/4] powerpc: tidy up dma_map_ops after adding new hook Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314855311.4145.8.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miltonm@bga.com \
--cc=nacc@us.ibm.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).