From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sethi Varun-B16395 <B16395@freescale.com>
Cc: "Linuxppc-dev@lists.ozlabs.org" <Linuxppc-dev@lists.ozlabs.org>
Subject: RE: [PATCH 3/4] powerpc/mpic: Move internal interrupt source vector allocation to a separate function.
Date: Thu, 05 Apr 2012 09:29:55 +1000 [thread overview]
Message-ID: <1333582195.3040.21.camel@pasglop> (raw)
In-Reply-To: <C5ECD7A89D1DC44195F34B25E172658D0B77F9@039-SN2MPN1-013.039d.mgd.msft.net>
On Wed, 2012-04-04 at 19:09 +0000, Sethi Varun-B16395 wrote:
> > I think that is more due to how you added the MPIC error interrupts
> and
> > issues w/that code. If you are treating the MPIC error interrupts
> as a
> > cascade than they should have a distinct linux IRQ space from the
> > standard MPIC interrupts. This is how the MSIs work (as an
> example).
> In case of error interrupts we are depending on the mpic_host_maps
> for mapping and interrupt specifier translations. There is no separate
> initialization as in case of MSIs. That's the reason I am treating
> error interrupts as mpic internal interrupt sources.
It makes sense to have an allocator for MPIC vectors but it should be a
single allocator shared with the MSI code.
Cheers,
Ben.
prev parent reply other threads:[~2012-04-04 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 12:16 [PATCH 3/4] powerpc/mpic: Move internal interrupt source vector allocation to a separate function Varun Sethi
2012-03-27 13:24 ` Kumar Gala
2012-03-27 13:52 ` Sethi Varun-B16395
2012-03-27 14:02 ` Kumar Gala
2012-04-04 19:09 ` Sethi Varun-B16395
2012-04-04 23:29 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333582195.3040.21.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=B16395@freescale.com \
--cc=Linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).