linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
Cc: jkenisto@linux.vnet.ibm.com, mahesh@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	paulus@samba.org, anton@samba.org
Subject: Re: [PATCH 4/8] Read/Write oops nvram partition via pstore
Date: Tue, 16 Apr 2013 09:14:35 +0200	[thread overview]
Message-ID: <1366096475.24994.50.camel@pasglop> (raw)
In-Reply-To: <516CEDB4.9090005@linux.vnet.ibm.com>

On Tue, 2013-04-16 at 11:50 +0530, Aruna Balakrishnaiah wrote:
> 
> Sure. I will have one #ifdef for declarations and one for function
> definitions.

Declarations generally don't need #ifdef's

Cheers,
Ben.
 

  reply	other threads:[~2013-04-16  7:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10  7:20 [PATCH 0/8] Nvram-to-pstore Aruna Balakrishnaiah
2013-04-10  7:21 ` [PATCH 1/8] Remove syslog prefix in uncompressed oops text Aruna Balakrishnaiah
2013-04-15  7:20   ` Michael Ellerman
2013-04-15  7:39     ` aruna
2013-04-10  7:21 ` [PATCH 2/8] Add version and timestamp to oops header Aruna Balakrishnaiah
2013-04-15  7:31   ` Michael Ellerman
2013-04-15  7:51     ` aruna
2013-04-10  7:21 ` [PATCH 3/8] Introduce generic read function to read nvram-partitions Aruna Balakrishnaiah
2013-04-15  7:35   ` Michael Ellerman
2013-04-10  7:23 ` [PATCH 4/8] Read/Write oops nvram partition via pstore Aruna Balakrishnaiah
2013-04-15  7:55   ` Michael Ellerman
2013-04-16  6:20     ` Aruna Balakrishnaiah
2013-04-16  7:14       ` Benjamin Herrenschmidt [this message]
2013-04-16  7:59         ` Aruna Balakrishnaiah
2013-04-17  5:19       ` Aruna Balakrishnaiah
2013-04-10  7:23 ` [PATCH 5/8] Read rtas " Aruna Balakrishnaiah
2013-04-15  8:01   ` Michael Ellerman
2013-04-16  6:21     ` Aruna Balakrishnaiah
2013-04-10  7:23 ` [PATCH 6/8] Distinguish between a os-partition and non-os partition Aruna Balakrishnaiah
2013-04-10  7:24 ` [PATCH 7/8] Read of-config partition via pstore Aruna Balakrishnaiah
2013-04-10  7:24 ` [PATCH 8/8] Read common " Aruna Balakrishnaiah
2013-04-15  7:36 ` [PATCH 0/8] Nvram-to-pstore Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366096475.24994.50.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=anton@samba.org \
    --cc=aruna@linux.vnet.ibm.com \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).