From: Scott Wood <scottwood@freescale.com>
To: Anthony Foiani <anthony.foiani@gmail.com>
Cc: Anthony Foiani <tkil@scrye.com>,
linuxppc-dev@lists.ozlabs.org,
Bhushan Bharat-R65777 <R65777@freescale.com>
Subject: Re: [PATCH] sata: fsl: save irqs while coalescing
Date: Mon, 19 Aug 2013 19:21:08 -0500 [thread overview]
Message-ID: <1376958068.31636.385.camel@snotra.buserror.net> (raw)
In-Reply-To: <1376936128-1624-1-git-send-email-anthony.foiani@gmail.com>
On Mon, 2013-08-19 at 12:15 -0600, Anthony Foiani wrote:
> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
> index 19720a0..851bd3f 100644
> --- a/drivers/ata/sata_fsl.c
> +++ b/drivers/ata/sata_fsl.c
> @@ -293,6 +293,7 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host,
> {
> struct sata_fsl_host_priv *host_priv = host->private_data;
> void __iomem *hcr_base = host_priv->hcr_base;
> + unsigned long flags;
>
> if (count > ICC_MAX_INT_COUNT_THRESHOLD)
> count = ICC_MAX_INT_COUNT_THRESHOLD;
> @@ -305,12 +306,12 @@ static void fsl_sata_set_irq_coalescing(struct ata_host *host,
> (count > ICC_MIN_INT_COUNT_THRESHOLD))
> ticks = ICC_SAFE_INT_TICKS;
>
> - spin_lock(&host->lock);
> + spin_lock_irqsave(&host->lock, flags);
> iowrite32((count << 24 | ticks), hcr_base + ICC);
>
> intr_coalescing_count = count;
> intr_coalescing_ticks = ticks;
> - spin_unlock(&host->lock);
> + spin_unlock_irqrestore(&host->lock, flags);
This should go to the SATA list and maintainer.
-Scott
next prev parent reply other threads:[~2013-08-20 0:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 1:39 MPC8315 reboot failure, lockdep splat possibly related? Anthony Foiani
2013-08-17 4:58 ` Bhushan Bharat-R65777
2013-08-17 17:17 ` Anthony Foiani
2013-08-18 0:07 ` Anthony Foiani
2013-08-18 17:00 ` Bhushan Bharat-R65777
2013-08-18 19:19 ` Anthony Foiani
2013-08-19 18:15 ` [PATCH] sata: fsl: save irqs while coalescing Anthony Foiani
2013-08-20 0:21 ` Scott Wood [this message]
2013-08-20 1:20 ` Anthony Foiani
2013-08-20 12:39 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376958068.31636.385.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=R65777@freescale.com \
--cc=anthony.foiani@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tkil@scrye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).