From: Ilia Mirkin <imirkin@alum.mit.edu>
To: linuxppc-dev@lists.ozlabs.org
Cc: Vinh Nguyen Huu Tuong <vhtnguyen@apm.com>,
Ilia Mirkin <imirkin@alum.mit.edu>
Subject: [PATCH] powerpc/44x: fix ocm_block allocation
Date: Fri, 6 Dec 2013 19:43:37 -0500 [thread overview]
Message-ID: <1386377017-909-1-git-send-email-imirkin@alum.mit.edu> (raw)
Allocate enough memory for the ocm_block structure, not just a pointer
to it.
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
---
I have neither the hardware to test nor the toolchain to even build-test
this. However this seems like a fairly obvious fix (and I have to wonder how
this ever worked at all). Found with spatch.
Actually further investigation makes it seem like this function is never
called, perhaps it should just be removed? If it is kept around though, would
be nice to apply this patch so that tools don't trip over this wrong code.
arch/powerpc/sysdev/ppc4xx_ocm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/ppc4xx_ocm.c b/arch/powerpc/sysdev/ppc4xx_ocm.c
index b7c4345..85d9e37 100644
--- a/arch/powerpc/sysdev/ppc4xx_ocm.c
+++ b/arch/powerpc/sysdev/ppc4xx_ocm.c
@@ -339,7 +339,7 @@ void *ppc4xx_ocm_alloc(phys_addr_t *phys, int size, int align,
if (IS_ERR_VALUE(offset))
continue;
- ocm_blk = kzalloc(sizeof(struct ocm_block *), GFP_KERNEL);
+ ocm_blk = kzalloc(sizeof(struct ocm_block), GFP_KERNEL);
if (!ocm_blk) {
printk(KERN_ERR "PPC4XX OCM: could not allocate ocm block");
rh_free(ocm_reg->rh, offset);
--
1.8.3.2
next reply other threads:[~2013-12-07 0:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-07 0:43 Ilia Mirkin [this message]
2013-12-09 8:38 ` [PATCH] powerpc/44x: fix ocm_block allocation Vinh Huu Tuong Nguyen
2013-12-09 15:28 ` Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386377017-909-1-git-send-email-imirkin@alum.mit.edu \
--to=imirkin@alum.mit.edu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vhtnguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).