From: Scott Wood <scottwood@freescale.com>
To: Valentin Longchamp <valentin.longchamp@keymile.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH RFC] powerpc/mpc85xx: add support for the kmp204x reference board
Date: Wed, 22 Jan 2014 14:33:14 -0600 [thread overview]
Message-ID: <1390422794.24905.510.camel@snotra.buserror.net> (raw)
In-Reply-To: <52DFF413.7060806@keymile.com>
On Wed, 2014-01-22 at 17:38 +0100, Valentin Longchamp wrote:
> On 01/21/2014 06:01 PM, Scott Wood wrote:
> > On Tue, 2014-01-21 at 17:34 +0100, Valentin Longchamp wrote:
> >> Can you please explicitly tell me how I should build this node ? What other
> >> comments ? Must I be more generic with the name ?
> >>
> >> Something like :
> >>
> >> spi@1 {
> >> compatible = "zarlink,30343", "spidev";
> >
> > Remove "spidev". Any nodes under the SPI controller node will be SPI
> > devices, right? So it doesn't add anything regarding hardware
> > description.
> >
>
> OK.
>
> Thank you for the feedback, I will then send a revised patch as soon as I have time.
Oh, and ideally the node name should describe the function of the device
-- "spi" as a node name usually means a SPI controller.
Maybe "ptp_clock@1"?
Also, zarlink should be added to
Documentation/devicetree/bindings/vendor-prefixes.txt
-Scott
prev parent reply other threads:[~2014-01-22 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:38 [PATCH RFC] powerpc/mpc85xx: add support for the kmp204x reference board Valentin Longchamp
2014-01-16 23:35 ` Scott Wood
2014-01-17 12:51 ` Valentin Longchamp
2014-01-17 21:48 ` Scott Wood
2014-01-20 16:38 ` Valentin Longchamp
2014-01-20 22:37 ` Scott Wood
2014-01-21 16:34 ` Valentin Longchamp
2014-01-21 17:01 ` Scott Wood
2014-01-22 16:38 ` Valentin Longchamp
2014-01-22 20:33 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390422794.24905.510.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=valentin.longchamp@keymile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).