From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
devicetree@vger.kernel.org, Dan Carpenter <error27@gmail.com>,
alistair@popple.id.au, josh@joshtriplett.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, David Miller <davem@davemloft.net>
Subject: Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)
Date: Fri, 07 Mar 2014 15:15:45 -0800 [thread overview]
Message-ID: <1394234145.16156.109.camel@joe-AO722> (raw)
In-Reply-To: <20140307230420.GH29018@mwanda>
On Sat, 2014-03-08 at 02:04 +0300, Dan Carpenter wrote:
> On Fri, Mar 07, 2014 at 01:30:17PM -0800, josh@joshtriplett.org wrote:
> > On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote:
> > > On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote:
> > > > From: Alistair Popple <alistair@popple.id.au>
> > > > Date: Thu, 6 Mar 2014 14:52:25 +1100
> > > >
> > > > > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN
> > > > > + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE);
> > > >
> > > > When an expression spans multiple lines, the lines should end with
> > > > operators rather than begin with them.
> > >
> > > That's not in CodingStyle currently.
> >
> > It's also not even remotely consistent across existing kernel code, and
> > it isn't obvious that there's a general developer consensus on the
> > "right" way to write it.
> >
>
> We just had this discussion in staging and Greg modified the patch to
> put the operator at the end.
>
> https://lkml.org/lkml/2014/2/25/125
I remember and it's the reason I bring it up in a
more public way.
> It's like logical && and || operators which go at the end these days.
> I don't really want to have a lot of checkpatch churn to convert
> everything...
Nor I really. I simply would like a tool that lets
more core maintainers like David M avoid sending out
"do this, not that" type emails about patches.
I don't mind adding style checking that emits something
for patches and is quieter when scanning files.
next prev parent reply other threads:[~2014-03-07 23:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 3:52 [PATCH 0/5] V2 IBM Akebono/PPC46GTR Support Alistair Popple
2014-03-06 3:52 ` [PATCH 1/5] SDHCI: Add a generic registration to the SDHCI platform driver Alistair Popple
2014-03-06 3:52 ` [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Alistair Popple
2014-03-07 20:41 ` David Miller
2014-03-07 21:02 ` rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver) Joe Perches
2014-03-07 21:23 ` rfc: checkpatch logical line continuations David Miller
2014-03-07 21:30 ` rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver) josh
2014-03-07 21:45 ` Joe Perches
2014-03-07 23:04 ` Dan Carpenter
2014-03-07 23:15 ` Joe Perches [this message]
2014-03-10 9:53 ` David Laight
2014-03-11 0:44 ` [PATCH 2/5 V2] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Alistair Popple
2014-05-02 0:48 ` Alistair Popple
2014-03-06 3:52 ` [PATCH 3/5] IBM Currituck: Clean up board specific code before adding Akebono code Alistair Popple
2014-03-06 3:52 ` [PATCH 4/5] IBM Akebono: Add the Akebono platform Alistair Popple
2014-05-01 9:27 ` [4/5] " Paul Bolle
2014-05-02 0:35 ` Alistair Popple
2014-05-02 2:33 ` Benjamin Herrenschmidt
2014-05-02 8:06 ` [PATCH] IBM Akebono: Remove obsolete config select Alistair Popple
2014-06-13 11:56 ` Paul Bolle
2014-06-20 0:10 ` Alistair Popple
2014-09-04 22:20 ` Paul Bolle
2014-09-05 2:39 ` Alistair Popple
2014-09-04 22:29 ` [4/5] IBM Akebono: Add the Akebono platform Paul Bolle
2014-03-06 3:52 ` [PATCH 5/5] powerpc: Added PCI MSI support using the HSTA module Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394234145.16156.109.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=error27@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).