From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, srivatsa.bhat@linux.vnet.ibm.com
Subject: Re: [PATCH v2 2/6] powernv:cpufreq: Create a powernv_cpu_to_core_mask() helper.
Date: Wed, 19 Mar 2014 10:37:27 +1100 [thread overview]
Message-ID: <1395185847.30666.22.camel@pasglop> (raw)
In-Reply-To: <1394449861-8688-3-git-send-email-ego@linux.vnet.ibm.com>
On Mon, 2014-03-10 at 16:40 +0530, Gautham R. Shenoy wrote:
> From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
>
> Create a helper method that computes the cpumask corresponding to the
> thread-siblings of a cpu. Use this for initializing the policy->cpus
> mask for a given cpu.
>
> (Original code written by Srivatsa S. Bhat. Gautham moved this to a
> helper function!)
How does that differ from the existing entry in the sibling map which
you can obtain with the helper cpu_sibling_mask() ? (You probably want
to *copy* the mask of course but I don't see the need of re-creating
one from scratch).
Also, this should have been CCed to the cpufreq mailing list and maybe
the relevant maintainer too.
Cheers,
Ben.
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
> Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> ---
> drivers/cpufreq/powernv-cpufreq.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index ab1551f..4cad727 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -115,6 +115,23 @@ static struct freq_attr *powernv_cpu_freq_attr[] = {
>
> /* Helper routines */
>
> +/**
> + * Sets the bits corresponding to the thread-siblings of cpu in its core
> + * in 'cpus'.
> + */
> +static void powernv_cpu_to_core_mask(unsigned int cpu, cpumask_var_t cpus)
> +{
> + int base, i;
> +
> + base = cpu_first_thread_sibling(cpu);
> +
> + for (i = 0; i < threads_per_core; i++) {
> + cpumask_set_cpu(base + i, cpus);
> + }
> +
> + return;
> +}
> +
> /* Access helpers to power mgt SPR */
>
> static inline unsigned long get_pmspr(unsigned long sprn)
> @@ -180,13 +197,8 @@ static int powernv_set_freq(cpumask_var_t cpus, unsigned int new_index)
>
> static int powernv_cpufreq_cpu_init(struct cpufreq_policy *policy)
> {
> - int base, i;
> -
> #ifdef CONFIG_SMP
> - base = cpu_first_thread_sibling(policy->cpu);
> -
> - for (i = 0; i < threads_per_core; i++)
> - cpumask_set_cpu(base + i, policy->cpus);
> + powernv_cpu_to_core_mask(policy->cpu, policy->cpus);
> #endif
> policy->cpuinfo.transition_latency = 25000;
>
next prev parent reply other threads:[~2014-03-18 23:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 11:10 [PATCH v2 0/6] powernv:cpufreq: Dynamic cpu-frequency scaling Gautham R. Shenoy
2014-03-10 11:10 ` [PATCH v2 1/6] powernv: cpufreq driver for powernv platform Gautham R. Shenoy
2014-03-10 11:10 ` [PATCH v2 2/6] powernv:cpufreq: Create a powernv_cpu_to_core_mask() helper Gautham R. Shenoy
2014-03-18 23:37 ` Benjamin Herrenschmidt [this message]
2014-03-19 6:35 ` Srivatsa S. Bhat
2014-03-19 11:02 ` Gautham R Shenoy
2014-03-10 11:10 ` [PATCH v2 3/6] powernv, cpufreq:Add per-core locking to serialize frequency transitions Gautham R. Shenoy
2014-03-17 9:04 ` Preeti U Murthy
2014-03-10 11:10 ` [PATCH v2 4/6] powernv:cpufreq: Create pstate_id_to_freq() helper Gautham R. Shenoy
2014-03-17 9:06 ` Preeti U Murthy
2014-03-10 11:11 ` [PATCH v2 5/6] powernv:cpufreq: Export nominal frequency via sysfs Gautham R. Shenoy
2014-03-10 11:11 ` [PATCH v2 6/6] powernv:cpufreq: Implement the driver->get() method Gautham R. Shenoy
2014-03-17 9:11 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395185847.30666.22.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).