From: Andrzej Hajda <a.hajda@samsung.com>
To: Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>
Cc: Milo Kim <milo.kim@ti.com>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
"open list:X86 PLATFORM DRIVERS"
<platform-driver-x86@vger.kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Yijing Wang <wangyijing@huawei.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"moderated list:ARM/S5P EXYNOS AR..."
<linux-samsung-soc@vger.kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
"moderated list:ARM/S5P EXYNOS AR..."
<linux-arm-kernel@lists.infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
open list <linux-kernel@vger.kernel.org>,
Rob Clark <robdclark@gmail.com>, Jon Mason <jdmason@kudzu.us>,
Joe Perches <joe@perches.com>,
"open list:LINUX FOR POWER M..." <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH 1/2] backlight: show brightness even if get_brightness is not implemented
Date: Fri, 30 May 2014 12:10:49 +0200 [thread overview]
Message-ID: <1401444650-12267-2-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1401444650-12267-1-git-send-email-a.hajda@samsung.com>
Many implementations of get_brightness operation returns only value
of props.brightness field. This change makes such implementations
unnecessary.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/video/backlight/backlight.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index 19b170d..0ce8823 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -221,6 +221,8 @@ static ssize_t actual_brightness_show(struct device *dev,
mutex_lock(&bd->ops_lock);
if (bd->ops && bd->ops->get_brightness)
rc = sprintf(buf, "%d\n", bd->ops->get_brightness(bd));
+ else
+ rc = sprintf(buf, "%d\n", bd->props.brightness);
mutex_unlock(&bd->ops_lock);
return rc;
--
1.9.1
next prev parent reply other threads:[~2014-05-30 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 10:10 [PATCH 0/2] backlight: remove trivial get_brightness implementations Andrzej Hajda
2014-05-30 10:10 ` Andrzej Hajda [this message]
2014-05-30 10:10 ` [PATCH 2/2] " Andrzej Hajda
2014-06-16 12:28 ` [PATCH 0/2] " Jingoo Han
2014-06-16 13:32 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401444650-12267-2-git-send-email-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=cooloney@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=geert@linux-m68k.org \
--cc=jdmason@kudzu.us \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=kgene.kim@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthew.garrett@nebula.com \
--cc=milo.kim@ti.com \
--cc=mpatocka@redhat.com \
--cc=plagnioj@jcrosoft.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robdclark@gmail.com \
--cc=sachin.kamat@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).