linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, Jimi Xenidis <jimix@pobox.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] powerpc: Remove platforms/wsp and associated pieces
Date: Mon, 02 Jun 2014 10:04:04 +0200	[thread overview]
Message-ID: <1401696244.14959.6.camel@x220> (raw)
In-Reply-To: <1401672046-17607-1-git-send-email-mpe@ellerman.id.au>

On Mon, 2014-06-02 at 11:20 +1000, Michael Ellerman wrote:
> __attribute__ ((unused))
> 
> WSP is the last user of CONFIG_PPC_A2, so we remove that as well.
> 
> Although CONFIG_PPC_ICSWX still exists, it's no longer selectable for
> any Book3E platform, so we can remove the code in mmu-book3e.h that
> depended on it.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  arch/powerpc/Kconfig.debug             |    5 -
>  arch/powerpc/configs/chroma_defconfig  |  307 ---------
>  arch/powerpc/include/asm/mmu-book3e.h  |    4 -
>  arch/powerpc/include/asm/reg_a2.h      |    9 -
>  arch/powerpc/include/asm/wsp.h         |   14 -
>  arch/powerpc/kernel/Makefile           |    1 -
>  arch/powerpc/kernel/cpu_setup_a2.S     |  120 ----
>  arch/powerpc/kernel/cputable.c         |   38 --
>  arch/powerpc/kernel/exceptions-64e.S   |   16 -
>  arch/powerpc/kernel/udbg.c             |    2 -
>  arch/powerpc/kernel/udbg_16550.c       |   11 -
>  arch/powerpc/platforms/Kconfig         |    1 -
>  arch/powerpc/platforms/Kconfig.cputype |    6 +-
>  arch/powerpc/platforms/Makefile        |    1 -
>  arch/powerpc/platforms/wsp/Kconfig     |   30 -
>  arch/powerpc/platforms/wsp/Makefile    |   10 -
>  arch/powerpc/platforms/wsp/chroma.c    |   56 --
>  arch/powerpc/platforms/wsp/h8.c        |  135 ----
>  arch/powerpc/platforms/wsp/ics.c       |  762 ---------------------
>  arch/powerpc/platforms/wsp/ics.h       |   25 -
>  arch/powerpc/platforms/wsp/msi.c       |  102 ---
>  arch/powerpc/platforms/wsp/msi.h       |   19 -
>  arch/powerpc/platforms/wsp/opb_pic.c   |  321 ---------
>  arch/powerpc/platforms/wsp/psr2.c      |   67 --
>  arch/powerpc/platforms/wsp/scom_smp.c  |  434 ------------

This (trivially) conflicts with commit 2751b628c97e ("powerpc: Fix SMP
issues with ppc64le ABIv2") in next-20140530.

>  arch/powerpc/platforms/wsp/scom_wsp.c  |   82 ---
>  arch/powerpc/platforms/wsp/setup.c     |   36 -
>  arch/powerpc/platforms/wsp/smp.c       |   88 ---
>  arch/powerpc/platforms/wsp/wsp.c       |  117 ----
>  arch/powerpc/platforms/wsp/wsp.h       |   29 -
>  arch/powerpc/platforms/wsp/wsp_pci.c   | 1134 --------------------------------
>  arch/powerpc/platforms/wsp/wsp_pci.h   |  268 --------
>  32 files changed, 1 insertion(+), 4249 deletions(-)
>  delete mode 100644 arch/powerpc/configs/chroma_defconfig
>  delete mode 100644 arch/powerpc/include/asm/wsp.h
>  delete mode 100644 arch/powerpc/kernel/cpu_setup_a2.S
>  delete mode 100644 arch/powerpc/platforms/wsp/Kconfig
>  delete mode 100644 arch/powerpc/platforms/wsp/Makefile
>  delete mode 100644 arch/powerpc/platforms/wsp/chroma.c
>  delete mode 100644 arch/powerpc/platforms/wsp/h8.c
>  delete mode 100644 arch/powerpc/platforms/wsp/ics.c
>  delete mode 100644 arch/powerpc/platforms/wsp/ics.h
>  delete mode 100644 arch/powerpc/platforms/wsp/msi.c
>  delete mode 100644 arch/powerpc/platforms/wsp/msi.h
>  delete mode 100644 arch/powerpc/platforms/wsp/opb_pic.c
>  delete mode 100644 arch/powerpc/platforms/wsp/psr2.c
>  delete mode 100644 arch/powerpc/platforms/wsp/scom_smp.c
>  delete mode 100644 arch/powerpc/platforms/wsp/scom_wsp.c
>  delete mode 100644 arch/powerpc/platforms/wsp/setup.c
>  delete mode 100644 arch/powerpc/platforms/wsp/smp.c
>  delete mode 100644 arch/powerpc/platforms/wsp/wsp.c
>  delete mode 100644 arch/powerpc/platforms/wsp/wsp.h
>  delete mode 100644 arch/powerpc/platforms/wsp/wsp_pci.c
>  delete mode 100644 arch/powerpc/platforms/wsp/wsp_pci.h

For what it's worth, according to my scripts this doesn't introduce
Kconfig related regressions (eg, you've removed all references to the
Kconfig symbols that were removed). And, of course, that puzzling check
for CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS is now gone.

Thanks,


Paul Bolle

  reply	other threads:[~2014-06-02  8:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02  1:20 [PATCH] powerpc: Remove platforms/wsp and associated pieces Michael Ellerman
2014-06-02  8:04 ` Paul Bolle [this message]
2014-06-05  3:04   ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2014-05-29  8:50 Michael Ellerman
2014-05-29  9:32 ` Stephen Rothwell
2014-05-29  9:39   ` Stephen Rothwell
2014-05-30  6:07     ` Michael Ellerman
2014-05-30  6:06   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401696244.14959.6.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=jimix@pobox.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).