From: Scott Wood <scottwood@freescale.com>
To: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
Cc: Martijn de Gouw <martijn.de.gouw@prodrive.nl>,
Barry.Wood@idt.com, Alexandre.Bounine@idt.com,
Liu Gang <Gang.Liu@freescale.com>,
stef.van.os@prodrive-technologies.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] fsl-rio: add support for mapping inbound windows
Date: Tue, 24 Jun 2014 19:40:57 -0500 [thread overview]
Message-ID: <1403656857.2435.61.camel@snotra.buserror.net> (raw)
In-Reply-To: <1403532715-21389-1-git-send-email-martijn.de.gouw@prodrive-technologies.com>
On Mon, 2014-06-23 at 16:11 +0200, Martijn de Gouw wrote:
> From: Martijn de Gouw <martijn.de.gouw@prodrive.nl>
>
> Add support for mapping and unmapping of inbound rapidio windows.
>
> Signed-off-by: Martijn de Gouw <martijn.de.gouw@prodrive-technologies.com>
> ---
> arch/powerpc/sysdev/fsl_rio.c | 92 +++++++++++++++++++++++++++++++++++++++++
> arch/powerpc/sysdev/fsl_rio.h | 12 ++++++
> 2 files changed, 104 insertions(+)
Could you describe a bit more why this is needed?
Liu Gang, can you review this?
> +int fsl_map_inb_mem(struct rio_mport *mport, dma_addr_t lstart,
> + u64 rstart, u32 size, u32 flags)
> +{
> + struct rio_priv *priv = mport->priv;
> + u32 base_size;
> + unsigned int base_size_log;
> + u64 win_start, win_end;
> + u32 riwar;
> + int i;
> +
> + base_size_log = __ilog2(size) + ((size & (size - 1)) != 0);
Why __ilog2() and not ilog2()?
> @@ -598,6 +687,8 @@ int fsl_rio_setup(struct platform_device *dev)
> RIO_ATMU_REGS_PORT2_OFFSET));
>
> priv->maint_atmu_regs = priv->atmu_regs + 1;
> + priv->inb_atmu_regs = (struct rio_inb_atmu_regs *)
> + (priv->regs_win + RIO_INB_ATMU_REGS_OFFSET);
__iomem
-Scott
next prev parent reply other threads:[~2014-06-25 0:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 14:11 [PATCH v2] fsl-rio: add support for mapping inbound windows Martijn de Gouw
2014-06-25 0:40 ` Scott Wood [this message]
2014-06-25 9:55 ` Gang.Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403656857.2435.61.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=Alexandre.Bounine@idt.com \
--cc=Barry.Wood@idt.com \
--cc=Gang.Liu@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martijn.de.gouw@prodrive-technologies.com \
--cc=martijn.de.gouw@prodrive.nl \
--cc=stef.van.os@prodrive-technologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).