linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: arnd@arndb.de, geoff@infradead.org, alistair@popple.id.au,
	scottwood@freescale.com, agust@denx.de, linux@roeck-us.net
Subject: [PATCH v2 00/20] powerpc: Convert power off logic to pm_power_off
Date: Mon, 13 Oct 2014 16:01:08 +0200	[thread overview]
Message-ID: <1413208888-49211-1-git-send-email-agraf@suse.de> (raw)

The generic Linux framework to power off the machine is a function pointer
called pm_power_off. The trick about this pointer is that device drivers can
potentially implement it rather than board files.

Today on PowerPC we set pm_power_off to invoke our generic full machine power
off logic which then calls ppc_md.power_off to invoke machine specific power
off.

However, when we want to add a power off GPIO via the "gpio-poweroff" driver,
this card house falls apart. That driver only registers itself if pm_power_off
is NULL to ensure it doesn't override board specific logic. However, since we
always set pm_power_off to the generic power off logic (which will just not
power off the machine if no ppc_md.power_off call is implemented), we can't
implement power off via the generic GPIO power off driver.

To fix this up, let's get rid of the ppc_md.power_off logic and just always use
pm_power_off as was intended. Then individual drivers such as the GPIO power off
driver can implement power off logic via that function pointer.

With this patch set applied and a few patches on top of QEMU that implement a
power off GPIO on the virt e500 machine, I can successfully turn off my virtual
machine after halt.

Michael / Ben, you can find this patch set as a git branch at the URL below.
When applying it, please use that one to ensure that Guenter can easily merge
his work with my work.

  git://github.com/agraf/linux-2.6.git pm_power_off-v2

Alex

---

v1 -> v2:

  - fix typo in 47x
  - put ppc_md static replacement setters into probe function

Alexander Graf (20):
  powerpc: Support override of pm_power_off
  powerpc/xmon: Support either ppc_md.power_off or pm_power_off
  powerpc/47x: Use pm_power_off rather than ppc_md.power_off
  powerpc/52xx/efika: Use pm_power_off rather than ppc_md.power_off
  powerpc/mpc8349emitx: Use pm_power_off rather than ppc_md.power_off
  powerpc/corenet: Use pm_power_off rather than ppc_md.power_off
  powerpc/85xx/sgy_cts1000: Use pm_power_off rather than
    ppc_md.power_off
  powerpc/celleb: Use pm_power_off rather than ppc_md.power_off
  powerpc/cell/qpace: Use pm_power_off rather than ppc_md.power_off
  powerpc/cell: Use pm_power_off rather than ppc_md.power_off
  powerpc/chrp: Use pm_power_off rather than ppc_md.power_off
  powerpc/6xx/gamecube: Use pm_power_off rather than ppc_md.power_off
  powerpc/6xx/linkstation: Use pm_power_off rather than ppc_md.power_off
  powerpc/6xx/wii: Use pm_power_off rather than ppc_md.power_off
  powerpc/maple: Use pm_power_off rather than ppc_md.power_off
  powerpc/powermac: Use pm_power_off rather than ppc_md.power_off
  powerpc/powernv: Use pm_power_off rather than ppc_md.power_off
  powerpc/ps3: Use pm_power_off rather than ppc_md.power_off
  powerpc/pseries: Use pm_power_off rather than ppc_md.power_off
  powerpc: Remove ppc_md.power_off

 arch/powerpc/include/asm/machdep.h               |   1 -
 arch/powerpc/kernel/setup-common.c               |   6 +-
 arch/powerpc/platforms/44x/ppc476.c              |   2 +-
 arch/powerpc/platforms/52xx/efika.c              |   3 +-
 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c   |   8 +-
 arch/powerpc/platforms/85xx/corenet_generic.c    |   2 +-
 arch/powerpc/platforms/85xx/sgy_cts1000.c        |   4 +-
 arch/powerpc/platforms/cell/celleb_setup.c       |   4 +-
 arch/powerpc/platforms/cell/qpace_setup.c        |   2 +-
 arch/powerpc/platforms/cell/setup.c              |   2 +-
 arch/powerpc/platforms/chrp/setup.c              |   3 +-
 arch/powerpc/platforms/embedded6xx/gamecube.c    |   3 +-
 arch/powerpc/platforms/embedded6xx/linkstation.c |   4 +-
 arch/powerpc/platforms/embedded6xx/wii.c         |   3 +-
 arch/powerpc/platforms/maple/setup.c             |   4 +-
 arch/powerpc/platforms/powermac/setup.c          | 147 ++++++++++++-----------
 arch/powerpc/platforms/powernv/setup.c           |   4 +-
 arch/powerpc/platforms/ps3/setup.c               |   2 +-
 arch/powerpc/platforms/pseries/setup.c           |  59 ++++-----
 arch/powerpc/sysdev/fsl_soc.c                    |   2 +-
 arch/powerpc/xmon/xmon.c                         |   3 +-
 21 files changed, 138 insertions(+), 130 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2014-10-13 14:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 14:01 Alexander Graf [this message]
2014-10-13 14:01 ` [PATCH v2 01/20] powerpc: Support override of pm_power_off Alexander Graf
2014-10-13 14:01 ` [PATCH v2 02/20] powerpc/xmon: Support either ppc_md.power_off or pm_power_off Alexander Graf
2014-10-13 14:01 ` [PATCH v2 03/20] powerpc/47x: Use pm_power_off rather than ppc_md.power_off Alexander Graf
2014-10-13 14:01 ` [PATCH v2 04/20] powerpc/52xx/efika: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 05/20] powerpc/mpc8349emitx: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 06/20] powerpc/corenet: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 07/20] powerpc/85xx/sgy_cts1000: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 08/20] powerpc/celleb: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 09/20] powerpc/cell/qpace: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 10/20] powerpc/cell: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 11/20] powerpc/chrp: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 12/20] powerpc/6xx/gamecube: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 13/20] powerpc/6xx/linkstation: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 14/20] powerpc/6xx/wii: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 15/20] powerpc/maple: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 16/20] powerpc/powermac: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 17/20] powerpc/powernv: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 18/20] powerpc/ps3: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 19/20] powerpc/pseries: " Alexander Graf
2014-10-13 14:01 ` [PATCH v2 20/20] powerpc: Remove ppc_md.power_off Alexander Graf
2014-10-13 15:47 ` [PATCH v2 00/20] powerpc: Convert power off logic to pm_power_off Guenter Roeck
2014-10-13 15:54 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413208888-49211-1-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=agust@denx.de \
    --cc=alistair@popple.id.au \
    --cc=arnd@arndb.de \
    --cc=geoff@infradead.org \
    --cc=linux@roeck-us.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).