From: Scott Wood <scottwood@freescale.com>
To: Kevin Hao <haokexin@gmail.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Gerhard Sittig <gsi@denx.de>,
Yuantian Tang <Yuantian.Tang@freescale.com>,
Jingchang Lu <jingchang.lu@freescale.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 1/3] Revert "clk: ppc-corenet: Fix Section mismatch warning"
Date: Wed, 3 Dec 2014 22:46:24 -0600 [thread overview]
Message-ID: <1417668384.15957.240.camel@freescale.com> (raw)
In-Reply-To: <20141204043816.GB14597@pek-khao-d1.corp.ad.wrs.com>
On Thu, 2014-12-04 at 12:38 +0800, Kevin Hao wrote:
> On Wed, Dec 03, 2014 at 10:04:51PM -0600, Scott Wood wrote:
> > On Wed, 2014-12-03 at 16:53 +0800, Kevin Hao wrote:
> > > This reverts commit da788acb28386aa896224e784954bb73c99ff26c.
> > >
> > > That commit tried to fix the section mismatch warning by moving the
> > > ppc_corenet_clk_driver struct to init section. This is definitely wrong
> > > because the kernel would free the memories occupied by this struct
> > > after boot while this driver is still registered in the driver core.
> > > The kernel would panic when accessing this driver struct.
> > >
> > > Cc: stable@vger.kernel.org # 3.17
> >
> > I don't see stable@vger.kernel.org in the actual CC list.
>
> With the above cc tag, Won't this get automatically included in the stable
> tree once it is merged into mainline? As I know, we only need to explicitly
> send the patch to stable@vger.kernel.org only when that patch was already
> merged into mainline without the corresponding cc stable tag and we also want
> the stable tree include it. Did I miss something?
I reread stable_kernel_rules.txt and it looks like you're right, though
usually it ends up on the real CC list anyway due to how git send-email
works.
Since only this first patch is a critical bugfix, and there's no
arch/powerpc content in that patch, I think it should go via Mike's tree
if it's to go in for 3.18 (if it's not already too late). Or, to keep
things simple given the dependency of the following patches, we could
batch them all together for -next and add a # 3.18 stable request.
-Scott
next prev parent reply other threads:[~2014-12-04 4:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 8:53 [PATCH v3 0/3] fix a kernel panic on fsl corenet board when CONFIG_CLK_PPC_CORENET is enabled Kevin Hao
2014-12-03 8:53 ` [PATCH v3 1/3] Revert "clk: ppc-corenet: Fix Section mismatch warning" Kevin Hao
2014-12-04 4:04 ` Scott Wood
2014-12-04 4:38 ` Kevin Hao
2014-12-04 4:46 ` Scott Wood [this message]
2014-12-04 6:06 ` Kevin Hao
2014-12-05 1:10 ` Scott Wood
2014-12-05 3:51 ` Scott Wood
2014-12-09 1:34 ` Kevin Hao
2015-01-17 19:32 ` Mike Turquette
2015-01-15 2:50 ` Yuantian Tang
2014-12-03 8:53 ` [PATCH v3 2/3] powerpc: call of_clk_init() from time_init() Kevin Hao
2014-12-03 8:53 ` [PATCH v3 3/3] clk: ppc-corenet: fix section mismatch warning Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417668384.15957.240.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=gsi@denx.de \
--cc=haokexin@gmail.com \
--cc=jingchang.lu@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).