From: Scott Wood <scottwood@freescale.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] powerpc32: properly clear page table when 0 is not a good default PTE value
Date: Wed, 10 Dec 2014 18:07:17 -0600 [thread overview]
Message-ID: <1418256437.5581.51.camel@freescale.com> (raw)
In-Reply-To: <20141210180037.C46001A5D62@localhost.localdomain>
On Wed, 2014-12-10 at 19:00 +0100, Christophe Leroy wrote:
> Some HW invert some PTE bits. In some case, __pte(0) is not 0 so the PTEs shall
> be properly set prior to being used.
__pte(0) is always zero. If that changes in a future patch, that patch
is not doing the right thing. The __pte()/pte_val() accesors should not
do anything beyond boxing/unboxing the value in a struct. The right
place for special 8xx handling of the inverted bit is in pte_mkwrite()
and such.
I don't see any other architecture using __pte()/pte_val() this way.
-Scott
prev parent reply other threads:[~2014-12-11 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 18:00 [PATCH 2/4] powerpc32: properly clear page table when 0 is not a good default PTE value Christophe Leroy
2014-12-11 0:07 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418256437.5581.51.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).