From: Scott Wood <scottwood@freescale.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Valentin Longchamp <valentin.longchamp@keymile.com>,
Linux device trees <devicetree@vger.kernel.org>,
danielle.costantino@gmail.com, "Boschung,
Rainer" <Rainer.Boschung@keymile.com>,
"Brunck, Holger" <Holger.Brunck@keymile.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux PowerPC Kernel <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler
Date: Fri, 26 Dec 2014 20:43:40 -0600 [thread overview]
Message-ID: <1419648220.5581.192.camel@freescale.com> (raw)
In-Reply-To: <20141223134940.GA1925@katana>
On Tue, 2014-12-23 at 14:49 +0100, Wolfram Sang wrote:
> On Tue, Dec 23, 2014 at 02:23:01PM +0100, Valentin Longchamp wrote:
> > Wolfgang, Scott,
>
> Wolfram, please.
>
> > > What is then the agreement here ? Add a clock-div to the device trees ? Or do
> > > something similar to mpc_i2c_get_sec_cfg_8xxx() ?
> > >
> > > I think the clock-div property is better according to Freescale's AN 2919
> > > section 3.1 Source clock. All the source clocks are fixed (with a clock-div of 2
> > > in case of mpc8536/43/45/47/48/67/68/72, plus p2020) except for the mpc8533/44
> > > where it can be 2 or 3, and that's what mpc_i2c_get_sec_cfg_8xxx() determines.
> > >
> > > So mpc_i2c_get_sec_cfg_8xxx() should remain the exception and the other
> > > prescaler values should be derived from an additional clock-div that must be
> > > added in the respective device trees (at least for the qoriq devices, because
> > > for instance mpc8543 already has the correct prescaler thanks to
> > > mpc_i2c_data_8543 from i2c-mpc.c).
> > >
> >
> > Do you have an opinion on the above ?
>
> I don't mind. I'll leave it to PowerPC experts to judge if a new binding
> is apropriate or reading SVR is the way to go. If it is going to be a
> new binding, then please look around before if there is already
> something similar around...
I'd rather use SVR so things work with existing device trees.
-Scott
prev parent reply other threads:[~2014-12-27 2:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 9:27 [PATCH] i2c-qoriq: modified compatibility for correct prescaler Valentin Longchamp
2014-10-28 23:08 ` Scott Wood
2014-10-29 8:59 ` Valentin Longchamp
2014-11-06 21:58 ` Scott Wood
2014-11-13 0:34 ` Wolfram Sang
2014-11-14 7:43 ` Valentin Longchamp
2014-11-14 8:28 ` Wolfram Sang
2014-11-18 1:28 ` Scott Wood
2014-11-25 18:13 ` Wolfram Sang
2014-11-26 1:41 ` Scott Wood
2014-11-30 4:30 ` Danielle Costantino
2014-12-01 17:23 ` Wolfram Sang
2014-12-11 13:44 ` Valentin Longchamp
2014-12-23 13:23 ` Valentin Longchamp
2014-12-23 13:49 ` Wolfram Sang
2014-12-27 2:43 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419648220.5581.192.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Holger.Brunck@keymile.com \
--cc=Rainer.Boschung@keymile.com \
--cc=danielle.costantino@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=valentin.longchamp@keymile.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).