From: Michael Ellerman <mpe@ellerman.id.au>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, mikey@neuling.org
Subject: Re: [RFC, 7/8] powerpc/xmon: Drop 'valid' from the condition inside 'dump_segments'
Date: Wed, 22 Jul 2015 14:52:34 +1000 [thread overview]
Message-ID: <1437540754.16792.10.camel@ellerman.id.au> (raw)
In-Reply-To: <55AE30E0.6060002@linux.vnet.ibm.com>
On Tue, 2015-07-21 at 17:15 +0530, Anshuman Khandual wrote:
> On 07/21/2015 03:30 PM, Michael Ellerman wrote:
> > On Tue, 2015-21-07 at 06:58:45 UTC, Anshuman Khandual wrote:
> >> > From: "khandual@linux.vnet.ibm.com" <khandual@linux.vnet.ibm.com>
> >> >
> >> > Value of 'valid' is zero when 'esid' is zero and it does not matter
> >> > when 'esid' is non-zero.
> > Yes it does. It tells you whether the entry is valid?
>
> Yeah but it does not change the outcome of the if condition check
> here. Non-zero esid will make the condition test pass irrespective
> of the value of 'valid'. Yes, valid will be checked inside the code
> block to print details, the point was value of valid does not make
> any difference to the 'if' condition check in the first place.
> Unless I am getting tricked here some how :)
No you're right, I was confused by the bitwise or.
Please make it: if (esid || vsid)
And drop valid entirely, just do the check in the if condition.
And fix the change log:
Hence the variable 'value'
^
valid
cheers
next prev parent reply other threads:[~2015-07-22 4:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 6:58 [RFC 1/8] powerpc/slb: Remove a duplicate extern variable Anshuman Khandual
2015-07-21 6:58 ` [RFC 2/8] powerpc/slb: Rename all the 'entry' occurrences to 'slot' Anshuman Khandual
2015-07-21 9:46 ` [RFC, " Michael Ellerman
2015-07-21 11:23 ` [RFC,2/8] " Anshuman Khandual
2015-07-21 6:58 ` [RFC 3/8] powerpc/slb: Define macros for the bolted slots Anshuman Khandual
2015-07-22 9:32 ` Michael Ellerman
2015-07-21 6:58 ` [RFC 4/8] powerpc/slb: Add some helper functions to improve modularization Anshuman Khandual
2015-07-22 9:19 ` Michael Ellerman
2015-07-21 6:58 ` [RFC 5/8] powerpc/slb: Add documentation to runtime patching of SLB encoding Anshuman Khandual
2015-07-22 5:51 ` Michael Ellerman
2015-07-22 5:57 ` Gabriel Paubert
2015-07-22 9:01 ` Michael Ellerman
2015-07-22 12:17 ` Segher Boessenkool
2015-07-21 6:58 ` [RFC 6/8] powerpc/prom: Simplify the logic while fetching SLB size Anshuman Khandual
2015-07-21 10:21 ` [RFC, " Michael Ellerman
2015-07-21 11:24 ` Anshuman Khandual
2015-07-21 6:58 ` [RFC 7/8] powerpc/xmon: Drop 'valid' from the condition inside 'dump_segments' Anshuman Khandual
2015-07-21 10:00 ` [RFC, " Michael Ellerman
2015-07-21 11:45 ` Anshuman Khandual
2015-07-22 4:52 ` Michael Ellerman [this message]
2015-07-21 6:58 ` [RFC 8/8] powerpc/xmon: Add some more elements to the existing PACA dump list Anshuman Khandual
2015-07-21 10:08 ` [RFC, " Michael Ellerman
2015-07-21 11:48 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437540754.16792.10.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).