From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: mpe@ellerman.id.au, mikey@neuling.org
Subject: [PATCH 7/8] powerpc/xmon: Drop the 'valid' variable completely in 'dump_segments'
Date: Wed, 29 Jul 2015 12:40:04 +0530 [thread overview]
Message-ID: <1438153805-31828-7-git-send-email-khandual@linux.vnet.ibm.com> (raw)
In-Reply-To: <1438153805-31828-1-git-send-email-khandual@linux.vnet.ibm.com>
Value of the 'valid' variable is zero when 'esid' is zero and it does
not matter when 'esid' is non-zero. The variable 'valid' can be dropped
from the function 'dump_segments' by checking for validity of 'esid'
inside the nested code block. This patch does that change.
Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
arch/powerpc/xmon/xmon.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index e599259..bc1b066a 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -2731,7 +2731,7 @@ static void xmon_print_symbol(unsigned long address, const char *mid,
void dump_segments(void)
{
int i;
- unsigned long esid,vsid,valid;
+ unsigned long esid,vsid;
unsigned long llp;
printf("SLB contents of cpu 0x%x\n", smp_processor_id());
@@ -2739,10 +2739,9 @@ void dump_segments(void)
for (i = 0; i < mmu_slb_size; i++) {
asm volatile("slbmfee %0,%1" : "=r" (esid) : "r" (i));
asm volatile("slbmfev %0,%1" : "=r" (vsid) : "r" (i));
- valid = (esid & SLB_ESID_V);
- if (valid | esid | vsid) {
+ if (esid || vsid) {
printf("%02d %016lx %016lx", i, esid, vsid);
- if (valid) {
+ if (esid & SLB_ESID_V) {
llp = vsid & SLB_VSID_LLP;
if (vsid & SLB_VSID_B_1T) {
printf(" 1T ESID=%9lx VSID=%13lx LLP:%3lx \n",
--
2.1.0
next prev parent reply other threads:[~2015-07-29 7:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 7:09 [PATCH 1/8] powerpc/slb: Remove a duplicate extern variable Anshuman Khandual
2015-07-29 7:09 ` [PATCH 2/8] powerpc/slb: Rename all the 'slot' occurrences to 'entry' Anshuman Khandual
2015-08-13 1:44 ` [2/8] " Michael Ellerman
2015-07-29 7:10 ` [PATCH 3/8] powerpc/slb: Define macros for the bolted slots Anshuman Khandual
2015-07-29 7:10 ` [PATCH 4/8] powerpc/slb: Add some helper functions to improve modularization Anshuman Khandual
2015-08-12 4:11 ` [4/8] " Michael Ellerman
2015-08-12 6:36 ` Anshuman Khandual
2015-07-29 7:10 ` [PATCH 5/8] powerpc/slb: Add documentation to runtime patching of SLB encoding Anshuman Khandual
2015-08-12 5:12 ` [5/8] " Michael Ellerman
2015-08-13 1:44 ` Michael Ellerman
2015-07-29 7:10 ` [PATCH 6/8] powerpc/prom: Simplify the logic while fetching SLB size Anshuman Khandual
2015-08-13 1:44 ` [6/8] " Michael Ellerman
2015-07-29 7:10 ` Anshuman Khandual [this message]
2015-08-13 1:44 ` [7/8] powerpc/xmon: Drop the 'valid' variable completely in 'dump_segments' Michael Ellerman
2015-07-29 7:10 ` [PATCH 8/8] powerpc/xmon: Add some more elements to the existing PACA dump list Anshuman Khandual
2015-08-12 6:05 ` Michael Ellerman
2015-08-12 6:27 ` Anshuman Khandual
2015-08-13 1:44 ` [1/8] powerpc/slb: Remove a duplicate extern variable Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438153805-31828-7-git-send-email-khandual@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).