From: Scott Wood <scottwood@freescale.com>
To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Wang Huan-B18965 <alison.wang@freescale.com>,
Jin Zhengxiong-R64188 <Jason.Jin@freescale.com>,
Zhao Chenhui-B35336 <chenhui.zhao@freescale.com>,
Tang Yuantian-B29983 <Yuantian.Tang@freescale.com>
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM
Date: Tue, 15 Sep 2015 21:19:15 -0500 [thread overview]
Message-ID: <1442369955.2909.166.camel@freescale.com> (raw)
In-Reply-To: <SN1PR0301MB1616C48FB3D990BCA45289AB9D5B0@SN1PR0301MB1616.namprd03.prod.outlook.com>
On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:
> Hi Scott,
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, September 16, 2015 7:57 AM
> > To: Wang Dongsheng-B40534
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org; Wang Huan-
> > B18965; Jin
> > Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
> > Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM
> >
> > On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote:
> > > +* Freescale RCPM Wakeup Source Device Tree Bindings
> > > +-------------------------------------------
> > > +Required rcpm-wakeup property should be added to a device node if the
> > > device
> > > +can be used as a wakeup source.
> > > +
> > > + - rcpm-wakeup: The value of the property consists of 3 cells. The
> > > first
> > > cell
> > > + is a pointer to the rcpm node, the second cell is the bit mask
> > > that
> > > + should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1.
> > > + Note: If the platform has no IPPDEXPCR1 register, put a zero here.
> >
> > What if a future platform has more than two of these registers?
>
> Those registers are only used for wakeup device, we have a lot of available
> bit
> for feature. For example, In LS1021a platform only 7bits has used in the
> registers,
> and 57bits is reserved.
Still, it'd be better to for the rcpm node to advertise the number of cells
it expects.
-Scott
next prev parent reply other threads:[~2015-09-16 2:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 8:55 [PATCH v2 1/2] fsl: Add binding for RCPM Dongsheng Wang
2015-09-15 8:55 ` [PATCH v2 2/2] arm/layerscape: add RCPM device tree support for ls1021a Dongsheng Wang
2015-09-15 23:56 ` [PATCH v2 1/2] fsl: Add binding for RCPM Scott Wood
2015-09-16 2:15 ` Wang Dongsheng
2015-09-16 2:19 ` Scott Wood [this message]
2015-09-16 2:30 ` Wang Dongsheng
2015-09-16 2:31 ` Scott Wood
2015-09-16 2:35 ` Yuantian Tang
2015-09-16 2:37 ` Scott Wood
2015-09-16 2:43 ` Wang Dongsheng
2015-09-16 3:18 ` Wang Dongsheng
2015-09-16 4:13 ` Scott Wood
2015-09-16 5:11 ` Wang Dongsheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442369955.2909.166.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=Dongsheng.Wang@freescale.com \
--cc=Jason.Jin@freescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=alison.wang@freescale.com \
--cc=chenhui.zhao@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).