linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Cyril Bur <cyrilbur@gmail.com>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH 4/9] powerpc: Explicitly disable math features when copying thread
Date: Mon, 29 Feb 2016 17:53:46 +1100	[thread overview]
Message-ID: <1456728831-31862-5-git-send-email-cyrilbur@gmail.com> (raw)
In-Reply-To: <1456728831-31862-1-git-send-email-cyrilbur@gmail.com>

Currently when threads get scheduled off they always giveup the FPU,
Altivec (VMX) and Vector (VSX) units if they were using them. When they are
scheduled back on a fault is then taken to enable each facility and load
registers. As a result explicitly disabling FPU/VMX/VSX has not been
necessary.

Future changes and optimisations remove this mandatory giveup and fault
which could cause calls such as clone() and fork() to copy threads and run
them later with FPU/VMX/VSX enabled but no registers loaded.

This patch starts the process of having MSR_{FP,VEC,VSX} mean that a
threads registers are hot while not having MSR_{FP,VEC,VSX} means that the
registers must be loaded. This allows for a smarter return to userspace.

Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
---
 arch/powerpc/kernel/process.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index dccc87e..e0c3d2d 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -1307,6 +1307,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
 
 		f = ret_from_fork;
 	}
+	childregs->msr &= ~(MSR_FP|MSR_VEC|MSR_VSX);
 	sp -= STACK_FRAME_OVERHEAD;
 
 	/*
-- 
2.7.2

  parent reply	other threads:[~2016-02-29  6:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29  6:53 [PATCH 0/9] FP/VEC/VSX switching optimisations Cyril Bur
2016-02-29  6:53 ` [PATCH 1/9] selftests/powerpc: Test the preservation of FPU and VMX regs across syscall Cyril Bur
2016-03-03 10:58   ` [1/9] " Michael Ellerman
2016-02-29  6:53 ` [PATCH 2/9] selftests/powerpc: Test preservation of FPU and VMX regs across preemption Cyril Bur
2016-02-29  6:53 ` [PATCH 3/9] selftests/powerpc: Test FPU and VMX regs in signal ucontext Cyril Bur
2016-02-29  6:53 ` Cyril Bur [this message]
2016-02-29  6:53 ` [PATCH 5/9] powerpc: Restore FPU/VEC/VSX if previously used Cyril Bur
2016-02-29  6:53 ` [PATCH 6/9] powerpc: Prepare for splitting giveup_{fpu, altivec, vsx} in two Cyril Bur
2016-02-29  6:53 ` [PATCH 7/9] powerpc: Add the ability to save FPU without giving it up Cyril Bur
2016-02-29  6:53 ` [PATCH 8/9] powerpc: Add the ability to save Altivec " Cyril Bur
2016-02-29  6:53 ` [PATCH 9/9] powerpc: Add the ability to save VSX " Cyril Bur
2016-02-29 23:02 ` [PATCH 0/9] FP/VEC/VSX switching optimisations Cyril Bur
2016-05-05 12:02 ` Naveen N. Rao
2016-05-06 10:48   ` Naveen N. Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456728831-31862-5-git-send-email-cyrilbur@gmail.com \
    --to=cyrilbur@gmail.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).