From: Michael Ellerman <mpe@ellerman.id.au>
To: Thomas Huth <thuth@redhat.com>,
Balbir Singh <bsingharora@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/pseries: Add POWER8NVL support to ibm,client-architecture-support call
Date: Wed, 08 Jun 2016 21:27:22 +1000 [thread overview]
Message-ID: <1465385242.13854.9.camel@ellerman.id.au> (raw)
In-Reply-To: <5757FEAC.2050002@redhat.com>
On Wed, 2016-06-08 at 13:17 +0200, Thomas Huth wrote:
> On 08.06.2016 12:44, Michael Ellerman wrote:
> > On Wed, 2016-06-08 at 11:14 +1000, Balbir Singh wrote:
> > > Don't we need to update IBM_ARCH_VEC_NRCORES_OFFSET as well?
> >
> > Yep, patch sent this morning.
>
> Ok, looks like BenH already posted a patch ...
And me before him :)
To be clear I'm not blaming you in any way for this, the existing code is
terrible and incredibly fragile.
> anyway, what do you think about aborting the boot process here in case cores
> != NR_CPUS, rather than just printing out a small warning which can easily get
> lost in the kernel log?
Yeah I agree it's easy to miss. And it's not part of dmesg (because it's from
prom_init()), so you *only* see it if you're actually staring at the console as
it boots (which is why my boot tests missed it).
I actually have plans to rewrite the whole thing to make it robust, so that
should avoid it ever being a problem again.
cheers
next prev parent reply other threads:[~2016-06-08 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 5:51 [PATCH] powerpc/pseries: Add POWER8NVL support to ibm, client-architecture-support call Thomas Huth
2016-05-31 10:04 ` [PATCH] powerpc/pseries: Add POWER8NVL support to ibm,client-architecture-support call Michael Ellerman
2016-05-31 10:19 ` Thomas Huth
2016-05-31 10:32 ` Michael Ellerman
2016-06-08 1:14 ` Balbir Singh
2016-06-08 10:44 ` Michael Ellerman
2016-06-08 11:17 ` Thomas Huth
2016-06-08 11:27 ` Michael Ellerman [this message]
2016-06-08 10:58 ` Thomas Huth
2016-06-06 0:17 ` powerpc/pseries: Add POWER8NVL support to ibm, client-architecture-support call Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465385242.13854.9.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).