linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-nvme@lists.infradead.org,
	Keith Busch <keith.busch@intel.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	linux-block@vger.kernel.org,
	Brian Norris <computersforpeace@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	linux-mtd@lists.infradead.org, "Ed L. Cashin" <ed.cashin@acm.org>,
	Jens Axboe <axboe@kernel.dk>, Minchan Kim <minchan@kernel.org>,
	virtualization@lists.linux-foundation.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Nitin Gupta <ngupta@vflare.org>,
	David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH 08/15] nvme: Pass attribute group to device_add_disk
Date: Wed, 17 Aug 2016 15:15:08 +0800	[thread overview]
Message-ID: <1471418115-3654-9-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1471418115-3654-1-git-send-email-famz@redhat.com>

Previously after device_add_disk returns, the KOBJ_ADD uevent is already
emitted. Adding attributes after that is a poor usage of kobject, and
in practice may result in race conditions with userspace, for
example udev checks availability of certain attributes and initializes
/dev entries conditionally.

device_add_disk can handle adding attribute group better, so use it.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 drivers/nvme/host/core.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 23a795f..1921cb2 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1686,11 +1686,7 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid)
 	if (ns->type == NVME_NS_LIGHTNVM)
 		return;
 
-	device_add_disk(ctrl->device, ns->disk, NULL);
-	if (sysfs_create_group(&disk_to_dev(ns->disk)->kobj,
-					&nvme_ns_attr_group))
-		pr_warn("%s: failed to create sysfs group for identification\n",
-			ns->disk->disk_name);
+	device_add_disk(ctrl->device, ns->disk, &nvme_ns_attr_group);
 	return;
  out_free_disk:
 	kfree(disk);
-- 
2.7.4

  parent reply	other threads:[~2016-08-17  7:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17  7:15 [PATCH 00/15] Fix issue with KOBJ_ADD uevent versus disk attributes Fam Zheng
2016-08-17  7:15 ` [PATCH 01/15] disk: Drop add_disk in favor of device_add_disk Fam Zheng
2016-08-17  7:15 ` [PATCH 02/15] genhd: Return error from register_disk() Fam Zheng
2016-08-17  7:15 ` [PATCH 03/15] genhd: Return error from blk_register_region Fam Zheng
2016-08-17  7:15 ` [PATCH 04/15] block: Return error from blk_integrity_add Fam Zheng
2016-08-17  7:15 ` [PATCH 05/15] genhd: Return error from disk_{add,alloc}_events Fam Zheng
2016-08-17  7:15 ` [PATCH 06/15] genhd: Add return code to device_add_disk Fam Zheng
2016-08-17  8:49   ` Cornelia Huck
2016-08-17  8:48     ` Fam Zheng
2016-08-17  9:06       ` Cornelia Huck
2016-08-17  9:14         ` Fam Zheng
2016-08-18  1:09           ` Ed Cashin
2016-08-17  7:15 ` [PATCH 07/15] genhd: Add attribute group parameter " Fam Zheng
2016-08-17  7:15 ` Fam Zheng [this message]
2016-08-17  8:13   ` [PATCH 08/15] nvme: Pass attribute group " kbuild test robot
2016-08-17  7:15 ` [PATCH 09/15] virtio-blk: " Fam Zheng
2016-09-04  4:18   ` Michael S. Tsirkin
2016-08-17  7:15 ` [PATCH 10/15] mtd: " Fam Zheng
2016-08-17  7:15 ` [PATCH 11/15] zram: " Fam Zheng
2016-08-18  1:59   ` Sergey Senozhatsky
2016-08-18  2:06     ` Sergey Senozhatsky
2016-08-17  7:15 ` [PATCH 12/15] mtip: " Fam Zheng
2016-08-17  7:15 ` [PATCH 13/15] aoeblk: " Fam Zheng
2016-08-17  7:15 ` [PATCH 14/15] axonram: " Fam Zheng
2016-08-17  7:15 ` [PATCH 15/15] block: Add FIXME comment to handle device_add_disk error Fam Zheng
2016-08-18  2:36   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471418115-3654-9-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=benh@kernel.crashing.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ed.cashin@acm.org \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=minchan@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=mst@redhat.com \
    --cc=ngupta@vflare.org \
    --cc=paulus@samba.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).