linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, mpe@ellerman.id.au
Cc: anton@samba.org, paulus@samba.org, npiggin@gmail.com,
	linuxppc-dev@lists.ozlabs.org,
	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: [PATCH v8 10/12] powerpc:Add new kconfig IRQ_DEBUG_SUPPORT
Date: Mon, 17 Apr 2017 06:47:35 +0530	[thread overview]
Message-ID: <1492391857-8606-11-git-send-email-maddy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1492391857-8606-1-git-send-email-maddy@linux.vnet.ibm.com>

New Kconfig is added "CONFIG_IRQ_DEBUG_SUPPORT" to add warn_on
to alert the invalid transitions. Also moved the code under
the CONFIG_TRACE_IRQFLAGS in arch_local_irq_restore() to new Kconfig.

Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/Kconfig      | 4 ++++
 arch/powerpc/kernel/irq.c | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 97a8bc8a095c..2c9ec0b37a80 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -46,6 +46,10 @@ config TRACE_IRQFLAGS_SUPPORT
 	bool
 	default y
 
+config IRQ_DEBUG_SUPPORT
+	bool
+	default n
+
 config LOCKDEP_SUPPORT
 	bool
 	default y
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index 835a08d9c48f..fe16975ae788 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -262,7 +262,7 @@ notrace void arch_local_irq_restore(unsigned long en)
 	 */
 	if (unlikely(irq_happened != PACA_IRQ_HARD_DIS))
 		__hard_irq_disable();
-#ifdef CONFIG_TRACE_IRQFLAGS
+#ifdef CONFIG_IRQ_DEBUG_SUPPORT
 	else {
 		/*
 		 * We should already be hard disabled here. We had bugs
@@ -273,7 +273,7 @@ notrace void arch_local_irq_restore(unsigned long en)
 		if (WARN_ON(mfmsr() & MSR_EE))
 			__hard_irq_disable();
 	}
-#endif /* CONFIG_TRACE_IRQFLAGS */
+#endif /* CONFIG_IRQ_DEBUG_SUPPORT */
 
 	soft_disable_mask_set(IRQ_DISABLE_MASK_LINUX);
 
-- 
2.7.4

  parent reply	other threads:[~2017-04-17  1:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17  1:17 [PATCH v8 00/12]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 01/12] powerpc: Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 02/12] powerpc: move set_soft_enabled() and rename Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 03/12] powerpc: Use soft_enabled_set api to update paca->soft_enabled Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 04/12] powerpc: Add soft_enabled manipulation functions Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 05/12] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 06/12] powerpc: Rename soft_enabled to soft_disable_mask Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 07/12] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 08/12] powerpc: Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 09/12] powerpc: Add support to mask perf interrupts and replay them Madhavan Srinivasan
2017-04-17  1:17 ` Madhavan Srinivasan [this message]
2017-04-17  1:17 ` [PATCH v8 11/12] powerpc: Add new set of soft_disable_mask_ functions Madhavan Srinivasan
2017-04-17  1:17 ` [PATCH v8 12/12] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
2017-05-10 19:11   ` [v8,12/12] " Steven Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492391857-8606-11-git-send-email-maddy@linux.vnet.ibm.com \
    --to=maddy@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).