From: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
To: clg@kaod.org, linux@roeck-us.net
Cc: jdelvare@suse.com, benh@kernel.crashing.org, paulus@samba.org,
mpe@ellerman.id.au, linux-hwmon@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
ego@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com,
stewart@linux.vnet.ibm.com,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Subject: [RFC] hwmon: (ibmpowernv) Add support for reset-history sensors
Date: Wed, 26 Jul 2017 11:25:38 +0530 [thread overview]
Message-ID: <1501048538-23160-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> (raw)
In P9, OCC allows for clearing the sensor min-max history. This patch
exports attribute to reset history when set will clear the history of
all the sensors owned by CSM and belonging to the chip.
Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
---
This patch is on top of this patchset:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1453891.html
This patch creates a non-standard attribute called as reset_historyX
which clears the lowest and highest of all the sensors like power,
temperature, voltage belonging to the chip.
drivers/hwmon/ibmpowernv.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
index 5ccdd0b..611e472 100644
--- a/drivers/hwmon/ibmpowernv.c
+++ b/drivers/hwmon/ibmpowernv.c
@@ -51,6 +51,7 @@ enum sensors {
POWER_SUPPLY,
POWER_INPUT,
CURRENT,
+ RESET_HISTORY,
MAX_SENSOR_TYPE,
};
@@ -78,6 +79,7 @@ enum sensors {
{ "in" },
{ "power" },
{ "curr" },
+ { "reset_history" },
};
struct sensor_data {
@@ -126,6 +128,25 @@ static ssize_t show_label(struct device *dev, struct device_attribute *devattr,
return sprintf(buf, "%s\n", sdata->label);
}
+static ssize_t store_reset_history(struct device *dev,
+ struct device_attribute *devattr,
+ const char *buf, size_t count)
+{
+ struct sensor_data *sdata = container_of(devattr, struct sensor_data,
+ dev_attr);
+ int rc;
+ int reset;
+
+ rc = kstrtoint(buf, 0, &reset);
+ if (rc)
+ return rc;
+
+ if (reset == 1)
+ rc = opal_sensor_groups_clear_history(sdata->id);
+
+ return rc ? rc : count;
+}
+
static int __init get_logical_cpu(int hwcpu)
{
int cpu;
@@ -458,6 +479,16 @@ static int create_device_attrs(struct platform_device *pdev)
create_hwmon_attr(&sdata[count], attr_name, show_sensor);
+ if (type == RESET_HISTORY) {
+ snprintf(sdata[count].name, MAX_ATTR_LEN, "%s%d",
+ sensor_groups[type].name,
+ sdata[count].hwmon_index);
+
+ sdata[count].dev_attr.attr.mode = 0220;
+ sdata[count].dev_attr.store = store_reset_history;
+ sdata[count].dev_attr.show = NULL;
+ }
+
pgroups[type]->attrs[sensor_groups[type].attr_count++] =
&sdata[count++].dev_attr.attr;
--
1.8.3.1
next reply other threads:[~2017-07-26 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 5:55 Shilpasri G Bhat [this message]
2017-08-09 4:32 ` [RFC] hwmon: (ibmpowernv) Add support for reset-history sensors Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501048538-23160-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com \
--to=shilpa.bhat@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=ego@linux.vnet.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=stewart@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).