linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: mpe@ellerman.id.au
Cc: benh@kernel.crashing.org, anton@samba.org, paulus@samba.org,
	npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org,
	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: [PATCH v9 06/14] powerpc/irq: Fix arch_local_irq_disable() in book3s
Date: Thu,  3 Aug 2017 09:19:10 +0530	[thread overview]
Message-ID: <1501732158-19009-7-git-send-email-maddy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1501732158-19009-1-git-send-email-maddy@linux.vnet.ibm.com>

In powerpc book3s, arch_local_irq_disable() function is not a "void"
when compared to other arch. And only user for this function is
arch_local_irq_save().

Patch modify the arch_local_irq_save() and makes arch_local_irq_disable()
to use arch_local_irq_save() instead.

Suggested-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/include/asm/hw_irq.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
index bf07031c88e6..8abd18c15650 100644
--- a/arch/powerpc/include/asm/hw_irq.h
+++ b/arch/powerpc/include/asm/hw_irq.h
@@ -93,11 +93,6 @@ static inline unsigned long arch_local_save_flags(void)
 	return soft_enabled_return();
 }
 
-static inline unsigned long arch_local_irq_disable(void)
-{
-	return soft_enabled_set_return(IRQ_DISABLED);
-}
-
 extern void arch_local_irq_restore(unsigned long);
 
 static inline void arch_local_irq_enable(void)
@@ -107,7 +102,12 @@ static inline void arch_local_irq_enable(void)
 
 static inline unsigned long arch_local_irq_save(void)
 {
-	return arch_local_irq_disable();
+	return soft_enabled_set_return(IRQ_DISABLED);
+}
+
+static inline void arch_local_irq_disable(void)
+{
+	arch_local_irq_save();
 }
 
 static inline bool arch_irqs_disabled_flags(unsigned long flags)
-- 
2.7.4

  parent reply	other threads:[~2017-08-03  3:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  3:49 [PATCH v9 00/14]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 01/14] powerpc: Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 02/14] powerpc: move set_soft_enabled() and rename Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 03/14] powerpc: Use soft_enabled_set api to update paca->soft_enabled Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 04/14] powerpc: Add soft_enabled manipulation functions Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 05/14] powerpc/irq: Cleanup hard_irq_disable() macro Madhavan Srinivasan
2017-08-03  3:49 ` Madhavan Srinivasan [this message]
2017-08-03  3:49 ` [PATCH v9 07/14] powerpc: Modify soft_enable from flag to mask Madhavan Srinivasan
2017-08-03  4:44   ` Nicholas Piggin
2017-08-03  3:49 ` [PATCH v9 08/14] powerpc: Rename soft_enabled to soft_disable_mask Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 09/14] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 10/14] powerpc: Add support to take additional parameter in MASKABLE_* macro Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 11/14] Add support to mask perf interrupts and replay them Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 12/14] powerpc:Add new kconfig IRQ_DEBUG_SUPPORT Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 13/14] powerpc: Add new set of soft_disable_mask_ functions Madhavan Srinivasan
2017-08-03  3:49 ` [PATCH v9 14/14] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
2017-08-03 17:50   ` Nicholas Piggin
2017-08-04  1:40     ` Benjamin Herrenschmidt
2017-08-04  9:04       ` Nicholas Piggin
2017-08-04 15:18         ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501732158-19009-7-git-send-email-maddy@linux.vnet.ibm.com \
    --to=maddy@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).