linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	mikey@neuling.org, hbabu@us.ibm.com, linuxppc-dev@ozlabs.org,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 05/10] powerpc/vas: Use helper to unpin/close window
Date: Sat, 16 Sep 2017 21:05:23 -0700	[thread overview]
Message-ID: <1505621128-23877-6-git-send-email-sukadev@linux.vnet.ibm.com> (raw)
In-Reply-To: <1505621128-23877-1-git-send-email-sukadev@linux.vnet.ibm.com>

Use a helper to have the hardware unpin and mark a window closed.

Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---
 arch/powerpc/platforms/powernv/vas-window.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c
index 8ab8a82..95622a9 100644
--- a/arch/powerpc/platforms/powernv/vas-window.c
+++ b/arch/powerpc/platforms/powernv/vas-window.c
@@ -1101,6 +1101,20 @@ static void poll_window_castout(struct vas_window *window)
 }
 
 /*
+ * Unpin and close a window so no new requests are accepted and the
+ * hardware can evict this window from cache if necessary.
+ */
+static void unpin_close_window(struct vas_window *window)
+{
+	u64 val;
+
+	val = read_hvwc_reg(window, VREG(WINCTL));
+	val = SET_FIELD(VAS_WINCTL_PIN, val, 0);
+	val = SET_FIELD(VAS_WINCTL_OPEN, val, 0);
+	write_hvwc_reg(window, VREG(WINCTL), val);
+}
+
+/*
  * Close a window.
  *
  * See Section 1.12.1 of VAS workbook v1.05 for details on closing window:
@@ -1114,8 +1128,6 @@ static void poll_window_castout(struct vas_window *window)
  */
 int vas_win_close(struct vas_window *window)
 {
-	u64 val;
-
 	if (!window)
 		return 0;
 
@@ -1131,11 +1143,7 @@ int vas_win_close(struct vas_window *window)
 
 	poll_window_busy_state(window);
 
-	/* Unpin window from cache and close it */
-	val = read_hvwc_reg(window, VREG(WINCTL));
-	val = SET_FIELD(VAS_WINCTL_PIN, val, 0);
-	val = SET_FIELD(VAS_WINCTL_OPEN, val, 0);
-	write_hvwc_reg(window, VREG(WINCTL), val);
+	unpin_close_window(window);
 
 	poll_window_castout(window);
 
-- 
2.7.4

  parent reply	other threads:[~2017-09-17  4:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17  4:05 [PATCH 00/10] powerpc/vas: cleanup and optimizations Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 01/10] powerpc/vas: init missing fields from [rt]xattr Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 02/10] powerpc/vas: Validate window credits Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 03/10] powerpc/vas: Cleanup some debug code Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 04/10] powerpc/vas: Drop poll_window_cast_out() Sukadev Bhattiprolu
2017-09-17  4:05 ` Sukadev Bhattiprolu [this message]
2017-09-17  4:05 ` [PATCH 06/10] powerpc/vas: Reduce polling interval for busy state Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 07/10] powerpc/vas: Save configured window credits Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 08/10] powerpc/vas: poll for return of " Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 09/10] powerpc/vas: Create cpu to vas id mapping Sukadev Bhattiprolu
2017-09-17  4:05 ` [PATCH 10/10] powerpc/vas, nx-842: Define and use chip_to_vas_id() Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505621128-23877-6-git-send-email-sukadev@linux.vnet.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=hbabu@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).