linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Dufour <ldufour@linux.vnet.ibm.com>
To: paulmck@linux.vnet.ibm.com, peterz@infradead.org,
	akpm@linux-foundation.org, kirill@shutemov.name,
	ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net,
	jack@suse.cz, Matthew Wilcox <willy@infradead.org>,
	benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	hpa@zytor.com, Will Deacon <will.deacon@arm.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	kemi.wang@intel.com, sergey.senozhatsky.work@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com,
	npiggin@gmail.com, bsingharora@gmail.com,
	Tim Chen <tim.c.chen@linux.intel.com>,
	linuxppc-dev@lists.ozlabs.org, x86@kernel.org
Subject: [PATCH v6 03/24] mm: Dont assume page-table invariance during faults
Date: Fri, 12 Jan 2018 18:25:47 +0100	[thread overview]
Message-ID: <1515777968-867-4-git-send-email-ldufour@linux.vnet.ibm.com> (raw)
In-Reply-To: <1515777968-867-1-git-send-email-ldufour@linux.vnet.ibm.com>

From: Peter Zijlstra <peterz@infradead.org>

One of the side effects of speculating on faults (without holding
mmap_sem) is that we can race with free_pgtables() and therefore we
cannot assume the page-tables will stick around.

Remove the reliance on the pte pointer.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

[Remove only if !CONFIG_SPF]
Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
---
 mm/memory.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mm/memory.c b/mm/memory.c
index 8a80986fff48..259f621345b2 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -2274,6 +2274,7 @@ int apply_to_page_range(struct mm_struct *mm, unsigned long addr,
 }
 EXPORT_SYMBOL_GPL(apply_to_page_range);
 
+#ifndef CONFIG_SPF
 /*
  * handle_pte_fault chooses page fault handler according to an entry which was
  * read non-atomically.  Before making any commitment, on those architectures
@@ -2297,6 +2298,7 @@ static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd,
 	pte_unmap(page_table);
 	return same;
 }
+#endif /* CONFIG_SPF */
 
 static inline void cow_user_page(struct page *dst, struct page *src, unsigned long va, struct vm_area_struct *vma)
 {
@@ -2884,11 +2886,13 @@ int do_swap_page(struct vm_fault *vmf)
 		swapcache = page;
 	}
 
+#ifndef CONFIG_SPF
 	if (!pte_unmap_same(vma->vm_mm, vmf->pmd, vmf->pte, vmf->orig_pte)) {
 		if (page)
 			put_page(page);
 		goto out;
 	}
+#endif
 
 	entry = pte_to_swp_entry(vmf->orig_pte);
 	if (unlikely(non_swap_entry(entry))) {
-- 
2.7.4

  parent reply	other threads:[~2018-01-12 17:26 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 17:25 [PATCH v6 00/24] Speculative page faults Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 01/24] x86/mm: Define CONFIG_SPF Laurent Dufour
2018-01-12 18:57   ` Thomas Gleixner
2018-01-15 17:37     ` Laurent Dufour
2018-01-15 17:49       ` Thomas Gleixner
2018-01-15 18:37         ` Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 02/24] powerpc/mm: " Laurent Dufour
2018-01-12 17:25 ` Laurent Dufour [this message]
2018-01-17  3:04   ` [PATCH v6 03/24] mm: Dont assume page-table invariance during faults Andi Kleen
2018-01-17  8:57     ` Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 04/24] mm: Prepare for FAULT_FLAG_SPECULATIVE Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 05/24] mm: Introduce pte_spinlock " Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 06/24] mm: VMA sequence count Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 07/24] mm: Protect VMA modifications using " Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 08/24] mm: protect mremap() against SPF hanlder Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 09/24] mm: Protect SPF handler against anon_vma changes Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 10/24] mm: Cache some VMA fields in the vm_fault structure Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 11/24] mm/migrate: Pass vm_fault pointer to migrate_misplaced_page() Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 12/24] mm: Introduce __lru_cache_add_active_or_unevictable Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 13/24] mm: Introduce __maybe_mkwrite() Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 14/24] mm: Introduce __vm_normal_page() Laurent Dufour
2018-01-12 17:25 ` [PATCH v6 15/24] mm: Introduce __page_add_new_anon_rmap() Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 16/24] mm: Protect mm_rb tree with a rwlock Laurent Dufour
2018-01-12 18:48   ` Matthew Wilcox
2018-01-15 17:42     ` Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 17/24] mm: Provide speculative fault infrastructure Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 18/24] mm: Try spin lock in speculative path Laurent Dufour
2018-01-12 18:18   ` Matthew Wilcox
2018-01-16 13:24     ` Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 19/24] mm: Adding speculative page fault failure trace events Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 20/24] perf: Add a speculative page fault sw event Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 21/24] perf tools: Add support for the SPF perf event Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 22/24] mm: Speculative page fault handler return VMA Laurent Dufour
2018-01-12 19:02   ` Matthew Wilcox
2018-01-13  4:23     ` Matthew Wilcox
2018-01-16 14:47       ` Laurent Dufour
2018-01-16 14:58         ` Matthew Wilcox
2018-01-12 17:26 ` [PATCH v6 23/24] x86/mm: Add speculative pagefault handling Laurent Dufour
2018-01-12 17:26 ` [PATCH v6 24/24] powerpc/mm: Add speculative page fault Laurent Dufour
2018-01-16 15:11 ` [PATCH v6 00/24] Speculative page faults Kirill A. Shutemov
2018-01-17 15:15   ` Laurent Dufour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1515777968-867-4-git-send-email-ldufour@linux.vnet.ibm.com \
    --to=ldufour@linux.vnet.ibm.com \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=bsingharora@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=haren@linux.vnet.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jack@suse.cz \
    --cc=kemi.wang@intel.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mhocko@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    --cc=will.deacon@arm.com \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).