From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Brian King <brking@linux.vnet.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [next-20230317][PPC/MLX5][bisected 4d5ab0a] Boot WARNING: CPU: 0 PID: 9 at net/core/dev.c:1928 call_netdevice_notifiers_info
Date: Wed, 22 Mar 2023 23:24:18 +0530 [thread overview]
Message-ID: <15173797-c28b-f1d9-9488-9cd4cebdaad4@linux.vnet.ibm.com> (raw)
In-Reply-To: <ZBheva8pJ3VJq/pO@lore-desk>
On 3/20/23 6:55 PM, Lorenzo Bianconi wrote:
>> Greeting's
>>
>> Warning is seen while booting kernels from 6.3.0-rc3-next-20230317 on my
>> powerpc Power 10 LPAR
>>
>> Boots fine without warnings when below patch is reverted
>>
>> commit 4d5ab0ad964df178beba031b89429a601893ff61
>> Author: Lorenzo Bianconi <lorenzo@kernel.org>
>> Date: Thu Mar 9 13:25:31 2023 +0100
>>
>> net/mlx5e: take into account device reconfiguration for xdp_features
>> flag
>>
>> Take into account LRO and GRO configuration setting device xdp_features
>> flag. Consider channel rq_wq_type enabling rx scatter-gatter support in
>> xdp_features flag and disable NETDEV_XDP_ACT_NDO_XMIT_SG since it is not
>> supported yet by the driver.
>> Moreover always enable NETDEV_XDP_ACT_NDO_XMIT as the ndo_xdp_xmit
>>
>> 4d5ab0ad got introduced in next-20230314
>>
>> @Lorenzo Could you please look into this
>
> I would say this issue has been already fixed by Jakub here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/net/core/xdp.c?id=769639c1fe8a98129aa97c8ee981639db1e8955c
Thanks Lorenzo,
Verified the patch and it fixes the problem and next-20230321 kernel
boots fine on my powerpc lpar
Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
--
Regard's
Abdul Haleem
IBM Linux Technology Center
prev parent reply other threads:[~2023-03-22 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 12:52 [next-20230317][PPC/MLX5][bisected 4d5ab0a] Boot WARNING: CPU: 0 PID: 9 at net/core/dev.c:1928 call_netdevice_notifiers_info Abdul Haleem
2023-03-20 13:25 ` Lorenzo Bianconi
2023-03-22 17:54 ` Abdul Haleem [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15173797-c28b-f1d9-9488-9cd4cebdaad4@linux.vnet.ibm.com \
--to=abdhalee@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).