From: Thomas Huth <thuth@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Laurent Vivier <lvivier@redhat.com>,
David Gibson <dgibson@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default
Date: Sun, 7 Apr 2019 14:51:12 +0200 [thread overview]
Message-ID: <15427d53-0008-7958-6b7c-914820f042c5@redhat.com> (raw)
In-Reply-To: <20190212103129.19de0cfc@umbus.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
On 12/02/2019 00.31, David Gibson wrote:
> On Mon, 11 Feb 2019 12:37:12 +0100
> Thomas Huth <thuth@redhat.com> wrote:
>
>> Recent versions of QEMU provide a XHCI device by default these
>> days instead of an old-fashioned OHCI device:
>>
>> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57040d451315320b7d27
>>
>> So to get the keyboard working in the graphical console there again,
>> we should now include XHCI support in the kernel by default, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Wow, we didn't before? That's bonkers.
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
>> ---
>> arch/powerpc/configs/pseries_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
>> index ea79c51..62e12f6 100644
>> --- a/arch/powerpc/configs/pseries_defconfig
>> +++ b/arch/powerpc/configs/pseries_defconfig
>> @@ -217,6 +217,7 @@ CONFIG_USB_MON=m
>> CONFIG_USB_EHCI_HCD=y
>> # CONFIG_USB_EHCI_HCD_PPC_OF is not set
>> CONFIG_USB_OHCI_HCD=y
>> +CONFIG_USB_XHCI_HCD=y
>> CONFIG_USB_STORAGE=m
>> CONFIG_NEW_LEDS=y
>> CONFIG_LEDS_CLASS=m
>> --
>> 1.8.3.1
Ping?
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2019-04-07 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 11:37 [PATCH] powerpc/configs: Enable CONFIG_USB_XHCI_HCD by default Thomas Huth
2019-02-11 23:31 ` David Gibson
2019-04-07 12:51 ` Thomas Huth [this message]
2019-04-08 11:48 ` Michael Ellerman
2019-02-12 1:36 ` Joel Stanley
2019-04-21 14:18 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15427d53-0008-7958-6b7c-914820f042c5@redhat.com \
--to=thuth@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=dgibson@redhat.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).