From: Viorel Suman <viorel.suman@nxp.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"timur@kernel.org" <timur@kernel.org>,
"Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
"tiwai@suse.com" <tiwai@suse.com>,
"nicoleotsuka@gmail.com" <nicoleotsuka@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"perex@perex.cz" <perex@perex.cz>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver
Date: Thu, 3 Jan 2019 13:47:16 +0000 [thread overview]
Message-ID: <1546523057.6408.8.camel@nxp.com> (raw)
In-Reply-To: <20181228233226.GA11728@bogus>
Hi Rob,
On Vi, 2018-12-28 at 17:32 -0600, Rob Herring wrote:
> On Tue, Dec 18, 2018 at 04:30:01PM +0000, Viorel Suman wrote:
> >
> > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs.
> > The Audio Mixer is a on-chip functional module that allows mixing
> > of
> > two audio streams into a single audio stream.
> >
> > Audio Mixer datasheet is available here:
> > https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
> >
> > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > ---
> > .../devicetree/bindings/sound/fsl,amix.txt | 45 ++
> This should be a separate patch.
Ok, thank you, will split this into several patches.
>
> >
> > sound/soc/fsl/Kconfig | 7 +
> > sound/soc/fsl/Makefile | 3 +
> > sound/soc/fsl/fsl_amix.c | 554
> > +++++++++++++++++++++
> > sound/soc/fsl/fsl_amix.h | 101 ++++
> > 5 files changed, 710 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/sound/fsl,amix.txt
> > create mode 100644 sound/soc/fsl/fsl_amix.c
> > create mode 100644 sound/soc/fsl/fsl_amix.h
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,amix.txt
> > b/Documentation/devicetree/bindings/sound/fsl,amix.txt
> > new file mode 100644
> > index 0000000..049144f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/fsl,amix.txt
> > @@ -0,0 +1,45 @@
> > +NXP Audio Mixer (AMIX).
> > +
> > +The Audio Mixer is a on-chip functional module that allows mixing
> > of two
> > +audio streams into a single audio stream. Audio Mixer has two
> > input serial
> > +audio interfaces. These are driven by two Synchronous Audio
> > interface
> > +modules (SAI). Each input serial interface carries 8 audio
> > channels in its
> > +frame in TDM manner. Mixer mixes audio samples of corresponding
> > channels
> > +from two interfaces into a single sample. Before mixing, audio
> > samples of
> > +two inputs can be attenuated based on configuration. The output of
> > the
> > +Audio Mixer is also a serial audio interface. Like input
> > interfaces it has
> > +the same TDM frame format. This output is used to drive the serial
> > DAC TDM
> > +interface of audio codec and also sent to the external pins along
> > with the
> > +receive path of normal audio SAI module for readback by the CPU.
> > +
> > +The output of Audio mixer can be selected from any of the three
> > streams
> > + - serial audio input 1
> > + - serial audio input 2
> > + - Mixed audio
> > +
> > +Mixing operation is independent of audio sample rate but the two
> > audio
> > +input streams must have same audio sample rate with same number of
> > channels
> > +in TDM frame to be eligible for mixing.
> > +
> > +Device driver required properties:
> > +=================================
> > + - compatible : Compatible list, contains
> > "fsl,imx8qm-amix"
> > +
> > + - reg : Offset and length of the register
> > set for the device.
> > +
> > + - clocks : Must contain an entry for each entry
> > in clock-names.
> > +
> > + - clock-names : Must include the "ipg" for
> > register access.
> Humm, no audio related clocks?
Right, no audio related clocks - Audio Mixer operates on the clocks
supplied by input Synchronous Audio Interfaces.
>
>
> >
> > +
> > + - power-domains : Must contain the phandle to the AMIX
> > power domain node
> > +
> > +Device driver configuration example:
> > +======================================
> > + amix: amix@59840000 {
> > + compatible = "fsl,imx8qm-amix";
> > + reg = <0x0 0x59840000 0x0 0x10000>;
> > + clocks = <&clk IMX8QXP_AUD_AMIX_IPG>;
> > + clock-names = "ipg";
> > + power-domains = <&pd_amix>;
> > + };
> > +
Regards,
Viorel
prev parent reply other threads:[~2019-01-03 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 16:30 [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver Viorel Suman
2018-12-26 17:24 ` Nicolin Chen
2019-01-03 15:56 ` Viorel Suman
2019-01-03 18:25 ` Rob Herring
2019-01-03 19:21 ` Viorel Suman
2019-01-03 20:03 ` Nicolin Chen
2019-01-04 8:52 ` Viorel Suman
2018-12-28 23:32 ` Rob Herring
2019-01-03 13:47 ` Viorel Suman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546523057.6408.8.camel@nxp.com \
--to=viorel.suman@nxp.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).