linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Hari Bathini <hbathini@linux.ibm.com>
To: linuxppc-dev <linuxppc-dev@ozlabs.org>
Cc: Ananth N Mavinakayanahalli <ananth@linux.ibm.com>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Vasant Hegde <hegdevasant@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Stewart Smith <stewart@linux.ibm.com>,
	Daniel Axtens <dja@axtens.net>
Subject: [PATCH v2 14/16] powernv/opalcore: provide an option to invalidate /proc/opalcore file
Date: Tue, 16 Apr 2019 16:06:03 +0530	[thread overview]
Message-ID: <155541096229.812.15671385900013752452.stgit@hbathini.in.ibm.com> (raw)
In-Reply-To: <155541065470.812.7120798773144842076.stgit@hbathini.in.ibm.com>

Writing '1' to /sys/kernel/fadump_release_opalcore would release the
memory held by kernel in exporting /proc/opalcore file.

Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
---
 arch/powerpc/platforms/powernv/opal-core.c |   39 ++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/opal-core.c b/arch/powerpc/platforms/powernv/opal-core.c
index 8bf687d..5503b8b 100644
--- a/arch/powerpc/platforms/powernv/opal-core.c
+++ b/arch/powerpc/platforms/powernv/opal-core.c
@@ -19,6 +19,8 @@
 #include <linux/proc_fs.h>
 #include <linux/elf.h>
 #include <linux/elfcore.h>
+#include <linux/kobject.h>
+#include <linux/sysfs.h>
 #include <linux/slab.h>
 #include <linux/crash_core.h>
 #include <linux/of.h>
@@ -532,6 +534,36 @@ static void opalcore_cleanup(void)
 }
 __exitcall(opalcore_cleanup);
 
+static ssize_t fadump_release_opalcore_store(struct kobject *kobj,
+					     struct kobj_attribute *attr,
+					     const char *buf, size_t count)
+{
+	int input = -1;
+
+	if (kstrtoint(buf, 0, &input))
+		return -EINVAL;
+
+	if (input == 1) {
+		if (oc_conf == NULL) {
+			pr_err("'/proc/opalcore' file does not exist!\n");
+			return -EPERM;
+		}
+
+		/*
+		 * Take away '/proc/opalcore' and release all memory
+		 * used for exporting this file.
+		 */
+		opalcore_cleanup();
+	} else
+		return -EINVAL;
+
+	return count;
+}
+
+static struct kobj_attribute opalcore_rel_attr = __ATTR(fadump_release_opalcore,
+						0200, NULL,
+						fadump_release_opalcore_store);
+
 /* Init function for opalcore module. */
 static int __init opalcore_init(void)
 {
@@ -558,6 +590,13 @@ static int __init opalcore_init(void)
 					     &proc_opalcore_operations);
 	if (oc_conf->proc_opalcore)
 		proc_set_size(oc_conf->proc_opalcore, oc_conf->opalcore_size);
+
+	rc = sysfs_create_file(kernel_kobj, &opalcore_rel_attr.attr);
+	if (rc) {
+		pr_warn("unable to create sysfs file fadump_release_opalcore (%d)\n",
+			rc);
+	}
+
 	return 0;
 }
 fs_initcall(opalcore_init);


  parent reply	other threads:[~2019-04-16 10:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 10:32 [PATCH v2 00/16] Add FADump support on PowerNV platform Hari Bathini
2019-04-16 10:33 ` [PATCH v2 01/16] powerpc/fadump: move internal fadump code to a new file Hari Bathini
2019-04-16 10:33 ` [PATCH v2 02/16] powerpc/fadump: Improve fadump documentation Hari Bathini
2019-04-16 10:33 ` [PATCH v2 03/16] pseries/fadump: move out platform specific support from generic code Hari Bathini
2019-04-16 10:33 ` [PATCH v2 04/16] powerpc/fadump: use FADump instead of fadump for how it is pronounced Hari Bathini
2019-04-16 10:34 ` [PATCH v2 05/16] powerpc/fadump: enable fadump support on OPAL based POWER platform Hari Bathini
2019-04-16 10:34 ` [PATCH v2 06/16] powerpc/fadump: Update documentation about OPAL platform support Hari Bathini
2019-04-16 10:34 ` [PATCH v2 07/16] powerpc/fadump: consider reserved ranges while reserving memory Hari Bathini
2019-04-16 10:34 ` [PATCH v2 08/16] powerpc/fadump: consider reserved ranges while releasing memory Hari Bathini
2019-04-16 10:35 ` [PATCH v2 09/16] powernv/fadump: process architected register state data provided by firmware Hari Bathini
2019-05-07 14:13   ` Mahesh J Salgaonkar
2019-05-07 16:00     ` Segher Boessenkool
2019-05-09  4:42       ` Hari Bathini
2019-04-16 10:35 ` [PATCH v2 10/16] powernv/fadump: add support to preserve crash data on FADUMP disabled kernel Hari Bathini
2019-04-16 10:35 ` [PATCH v2 11/16] powerpc/fadump: update documentation about CONFIG_PRESERVE_FA_DUMP Hari Bathini
2019-04-16 10:35 ` [PATCH v2 12/16] powerpc/powernv: export /proc/opalcore for analysing opal crashes Hari Bathini
2019-05-08  0:25   ` Nicholas Piggin
2019-05-09  4:46     ` Hari Bathini
2019-04-16 10:35 ` [PATCH v2 13/16] powernv/fadump: Skip processing /proc/vmcore when only OPAL core exists Hari Bathini
2019-04-16 10:36 ` Hari Bathini [this message]
2019-04-16 10:36 ` [PATCH v2 15/16] powernv/fadump: consider f/w load area Hari Bathini
2019-05-07 17:13   ` Mahesh J Salgaonkar
2019-05-09  4:50     ` Hari Bathini
2019-04-16 10:36 ` [PATCH v2 16/16] powernv/fadump: update documentation about option to release opalcore Hari Bathini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155541096229.812.15671385900013752452.stgit@hbathini.in.ibm.com \
    --to=hbathini@linux.ibm.com \
    --cc=ananth@linux.ibm.com \
    --cc=dja@axtens.net \
    --cc=hegdevasant@linux.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=stewart@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).