From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: sachinp <sachinp@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-scsi <linux-scsi@vger.kernel.org>,
martin.petersen@oracle.com,
manvanth <manvanth@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
hmadhani@marvell.com,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra
Date: Mon, 19 Aug 2019 15:56:50 +0530 [thread overview]
Message-ID: <1566210410.25520.5.camel@abdul.in.ibm.com> (raw)
In-Reply-To: <7fc59d4c-b3d5-5ec8-cb7c-51cb863f2a77@acm.org>
On Wed, 2019-08-14 at 20:42 -0700, Bart Van Assche wrote:
> On 8/14/19 10:18 AM, Abdul Haleem wrote:
> > On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote:
> >> On 8/14/19 9:52 AM, Abdul Haleem wrote:
> >>> Greeting's
> >>>
> >>> Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning on my powerpc power 8 lpar
> >>>
> >>> The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain if sp->done() is not...)
> >>>
> >>> boot logs:
> >>>
> >>> WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784
> >>
> >> Hi Abdul,
> >>
> >> Thank you for having reported this. Is that the only warning reported on your setup by the qla2xxx
> >> driver? If that warning is commented out, does the qla2xxx driver work as expected?
> >
> > boot warning did not show up when the commit is reverted.
> >
> > should I comment out only the WARN_ON_ONCE() which is causing the issue,
> > and not the other one ?
>
> Yes please. Commit 88263208 introduced five kernel warnings but I think
> only one of these should be removed again, e.g. as follows:
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index cd39ac18c5fd..d81b5ecce24b 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2780,8 +2780,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct
> rsp_que *rsp, void *pkt)
>
> if (rsp->status_srb == NULL)
> sp->done(sp, res);
> - else
> - WARN_ON_ONCE(true);
> }
>
> /**
Applying above patch on system boots fine.
i.e no warnings pop up when keeping all WARN_ON_ONCE() except above one.
Reported-and-Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
prev parent reply other threads:[~2019-08-19 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 16:52 [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra Abdul Haleem
2019-08-14 17:05 ` Bart Van Assche
2019-08-14 17:18 ` Abdul Haleem
2019-08-15 3:42 ` Bart Van Assche
2019-08-19 10:26 ` Abdul Haleem [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566210410.25520.5.camel@abdul.in.ibm.com \
--to=abdhalee@linux.vnet.ibm.com \
--cc=bvanassche@acm.org \
--cc=hmadhani@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manvanth@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).