From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8125DC10F14 for ; Tue, 15 Oct 2019 18:44:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB3692086A for ; Tue, 15 Oct 2019 18:44:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="ih4zeCbn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB3692086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46t48l3GZWzDr6b for ; Wed, 16 Oct 2019 05:44:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lca.pw (client-ip=2607:f8b0:4864:20::843; helo=mail-qt1-x843.google.com; envelope-from=cai@lca.pw; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lca.pw header.i=@lca.pw header.b="ih4zeCbn"; dkim-atps=neutral Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46t4695n9wzDqWw for ; Wed, 16 Oct 2019 05:42:07 +1100 (AEDT) Received: by mail-qt1-x843.google.com with SMTP id m15so32114326qtq.2 for ; Tue, 15 Oct 2019 11:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=YXiUOqo8ETclVClbFsr4YOWOeJ7XlxA5Qh2JOUOHtn0=; b=ih4zeCbnEW9LSQmgDID0erLrP4wKSRd4quPFdjB7jDfMBRahOCBa+C67Dy1NqHkrCv VJSNTqSrY43O2EJhupvXVshQ0BC82dIhxESVHTwLHkCEPN42OBS3yBTYdKusIr1FPyqX wpUPZ/cGTRy5YK2T6ObGKxHp1+6vi2CjoWlyTCo/dPXrhBn0tNseTwJyJuKrduDqfttY fd4SW/I4j0BpnaIdz6zO9hqQf6+agjiuheLCXQaQrYEDCeHJq0DF3gEtcT6Uvp1RF+B9 gDgx+ctEQBhsj7GuizlLnNWuM5pbIfjPRVvTdcRA7Ese4V0mQHl7lb1qg7KFEBXx5acS G4wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=YXiUOqo8ETclVClbFsr4YOWOeJ7XlxA5Qh2JOUOHtn0=; b=XxUmTXd3WDd2ZHOemOzHCjlNpSx6M6xIjStnKlll/3jKCUmhzjUurGqxlohjVNpRtM 2jppj8RwnE/Wh1iJVU3bx2G/UVf0HiWu+QO31p09p+8xW+rBDCTjgbgspC9Ezk9szon1 sjJXq4TlyHNccksk19il/uO/ATjcY1Lkmugqm3FCsQLSix9r6GY9W2ooW/CtFsz+tNHA TXKxDtKTJVzEF9PV3brNAllCf6sr7Wj5ps5Wi+cxpYQaNr+DOx4OirCH8JBEY0/yH5Ew Y1NR2dATEKttgf502yHwlwUMnl3wvsU/d47sN7b2eetSA9LcyQxn/xfYS4/4UdLnh05O Ijaw== X-Gm-Message-State: APjAAAXIGvhHQ4unGIKHz/WVGZMRLRXT5u09PYE4V8/yUqTuxIQpeqzz l6IAL1ipTvA94Sn+KOjdmBh1pg== X-Google-Smtp-Source: APXvYqwar5I/V60pS57/UcDUw1cogFuq6+7hHVlNRpscniqz5EATufxt8kONpUilAAyTNCHiUcXZ9w== X-Received: by 2002:ac8:1c49:: with SMTP id j9mr41218038qtk.364.1571164924491; Tue, 15 Oct 2019 11:42:04 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id o28sm9204198qkk.106.2019.10.15.11.42.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2019 11:42:03 -0700 (PDT) Message-ID: <1571164920.5937.45.camel@lca.pw> Subject: Re: [PATCH V6 0/2] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Anshuman Khandual , linux-mm@kvack.org Date: Tue, 15 Oct 2019 14:42:00 -0400 In-Reply-To: References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571150502.5937.39.camel@lca.pw> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Jason Gunthorpe , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , "Kirill A . Shutemov" , Dan Williams , Vlastimil Babka , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 2019-10-15 at 20:51 +0530, Anshuman Khandual wrote: > > On 10/15/2019 08:11 PM, Qian Cai wrote: > > The x86 will crash with linux-next during boot due to this series (v5) with the > > config below plus CONFIG_DEBUG_VM_PGTABLE=y. I am not sure if v6 would address > > it. > > > > https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config > > > > [ 33.862600][ T1] page:ffffea0009000000 is uninitialized and poisoned > > [ 33.862608][ T1] raw: ffffffffffffffff ffffffffffffffff ffffffffffffffff > > ffffff871140][ T1] ? _raw_spin_unlock_irq+0x27/0x40 > > [ 33.871140][ T1] ? rest_init+0x307/0x307 > > [ 33.871140][ T1] kernel_init+0x11/0x139 > > [ 33.871140][ T1] ? rest_init+0x307/0x307 > > [ 33.871140][ T1] ret_from_fork+0x27/0x50 > > [ 33.871140][ T1] Modules linked in: > > [ 33.871140][ T1] ---[ end trace e99d392b0f7befbd ]--- > > [ 33.871140][ T1] RIP: 0010:alloc_gigantic_page_order+0x3fe/0x490 > > Hmm, with defconfig (DEBUG_VM=y and DEBUG_VM_PGTABLE=y) it does not crash but > with the config above, it does. Just wondering if it is possible that these > pages might not been initialized yet because DEFERRED_STRUCT_PAGE_INIT=y ? Yes, this patch works fine. diff --git a/init/main.c b/init/main.c index 676d8020dd29..591be8f9e8e0 100644 --- a/init/main.c +++ b/init/main.c @@ -1177,7 +1177,6 @@ static noinline void __init kernel_init_freeable(void) workqueue_init(); init_mm_internals(); - debug_vm_pgtable(); do_pre_smp_initcalls(); lockup_detector_init(); @@ -1186,6 +1185,8 @@ static noinline void __init kernel_init_freeable(void) sched_init_smp(); page_alloc_init_late(); + debug_vm_pgtable(); + /* Initialize page ext after all struct pages are initialized. */ page_ext_init(); > > [ 13.898549][ T1] page:ffffea0005000000 is uninitialized and poisoned > [ 13.898549][ T1] raw: ffffffffffffffff ffffffffffffffff ffffffffffffffff ffffffffffffffff > [ 13.898549][ T1] raw: ffffffffffffffff ffffffffffffffff ffffffffffffffff ffffffffffffffff > [ 13.898549][ T1] page dumped because: VM_BUG_ON_PAGE(PagePoisoned(p)) > [ 13.898549][ T1] ------------[ cut here ]------------ > [ 13.898549][ T1] kernel BUG at ./include/linux/mm.h:1107! > [ 13.898549][ T1] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN PTI > [ 13.898549][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.4.0-rc3-next-20191015+ #